Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 14:10:11 +01:00
Code Issues Projects Releases Packages Wiki Activity

Makes layout respect <textarea> cols attribute

Browse source
This commit is contained in:
Matthew Rasmus 2014-12-12 11:56:54 -08:00
parent 905c30d697
commit 2c7f6076d1
4 changed files with 52 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

18
components/style/legacy.rs
View file

@ -26,6 +26,7 @@ pub enum LengthAttribute {
pub enum IntegerAttribute {
/// `<input size>`
SizeIntegerAttribute,
ColsIntegerAttribute,
}
/// Legacy presentational attributes that take a nonnegative integer as defined in HTML5 § 2.4.4.2.
@ -160,6 +161,23 @@ impl PresentationalHintSynthesis for Stylist {
Some(_) | None => {}
}
}
name if *name == atom!("textarea") => {
match element.get_integer_attribute(ColsIntegerAttribute) {
Some(value) if value != 0 => {
// TODO ServoCharacterWidth uses the size math for <input type="text">, but
// the math for <textarea> is a little different since we need to take
// scrollbar size into consideration (but we don't have a scrollbar yet!)
//
// https://html.spec.whatwg.org/multipage/rendering.html#textarea-effective-width
let value = specified::ServoCharacterWidth(value);
matching_rules_list.vec_push(DeclarationBlock::from_declaration(
WidthDeclaration(SpecifiedValue(specified::LPA_Length(
value)))));
*shareable = false
}
Some(_) | None => {}
}
}
_ => {}
}
}