From 2cbf7f4c7a7925d3aec4bed36805eaaaa46b2dc1 Mon Sep 17 00:00:00 2001 From: Ms2ger Date: Tue, 25 Feb 2014 09:34:29 +0100 Subject: [PATCH] Rewrite Document::SetTitle to use a match. --- src/components/script/dom/document.rs | 30 +++++++++++++-------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/src/components/script/dom/document.rs b/src/components/script/dom/document.rs index e839e4aa233..9854bb7e386 100644 --- a/src/components/script/dom/document.rs +++ b/src/components/script/dom/document.rs @@ -307,25 +307,25 @@ impl Document { child.get().type_id == ElementNodeTypeId(HTMLHeadElementTypeId) }); head_node.as_mut().map(|head| { - let mut title_node = head.children().find(|child| { child.get().type_id == ElementNodeTypeId(HTMLTitleElementTypeId) }); - title_node.as_mut().map(|title_node| { - for mut title_child in title_node.children() { - title_node.RemoveChild(&mut title_child); - } - let new_text = self.CreateTextNode(abstract_self, title.clone()); - title_node.AppendChild(&mut NodeCast::from(&new_text)); - }); - - if title_node.is_none() { - let mut new_title: JS = - NodeCast::from(&HTMLTitleElement::new(~"title", abstract_self)); - let new_text = self.CreateTextNode(abstract_self, title.clone()); - new_title.AppendChild(&mut NodeCast::from(&new_text)); - head.AppendChild(&mut new_title); + match title_node { + Some(ref mut title_node) => { + for mut title_child in title_node.children() { + title_node.RemoveChild(&mut title_child); + } + let new_text = self.CreateTextNode(abstract_self, title.clone()); + title_node.AppendChild(&mut NodeCast::from(&new_text)); + }, + None => { + let mut new_title: JS = + NodeCast::from(&HTMLTitleElement::new(~"title", abstract_self)); + let new_text = self.CreateTextNode(abstract_self, title.clone()); + new_title.AppendChild(&mut NodeCast::from(&new_text)); + head.AppendChild(&mut new_title); + }, } }); });