Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-29 18:20:24 +01:00
Code Issues Projects Releases Packages Wiki Activity

Remove fixme for if let in lints and replace with unreachable!()

Browse source
This commit is contained in:
Manish Goregaokar 2015-08-04 07:47:21 +05:30
parent 1809748dc1
commit 2d01e969f1
1 changed files with 6 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

10
components/plugins/lints/unrooted_must_root.rs
View file

@ -202,10 +202,12 @@ impl LintPass for UnrootedPass {
// We need not check arms individually since enum/struct fields are already
// linted in `check_struct_def` and `check_variant`
// (so there is no way of destructuring out a `#[must_root]` field)
ast::ExprMatch(ref e, _, _) |
// For loops allow you to bind a return value locally
ast::ExprForLoop(_, ref e, _, _) => &**e,
// XXXManishearth look into `if let` once it lands in our rustc
ast::ExprMatch(ref e, _, _) => &**e,
// These are able to bind local variables, but are desugared into
// loops and matches pre-lint so should not be encountered
ast::ExprForLoop(..) => unreachable!(),
ast::ExprIfLet(..) => unreachable!(),
ast::ExprWhileLet(..) => unreachable!(),
_ => return
},
_ => return