mirror of
https://github.com/servo/servo.git
synced 2025-08-05 05:30:08 +01:00
Use feature try_borrow instead of borrow_state in script
This commit is contained in:
parent
ef2ee4646f
commit
2e310f83ad
2 changed files with 32 additions and 45 deletions
|
@ -6,7 +6,7 @@
|
||||||
|
|
||||||
use dom::bindings::trace::JSTraceable;
|
use dom::bindings::trace::JSTraceable;
|
||||||
use js::jsapi::JSTracer;
|
use js::jsapi::JSTracer;
|
||||||
use std::cell::{BorrowState, Ref, RefCell, RefMut};
|
use std::cell::{BorrowError, BorrowMutError, Ref, RefCell, RefMut};
|
||||||
use util::thread_state;
|
use util::thread_state;
|
||||||
use util::thread_state::SCRIPT;
|
use util::thread_state::SCRIPT;
|
||||||
|
|
||||||
|
@ -52,49 +52,6 @@ impl<T> DOMRefCell<T> {
|
||||||
&mut *self.value.as_unsafe_cell().get()
|
&mut *self.value.as_unsafe_cell().get()
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Is the cell mutably borrowed?
|
|
||||||
///
|
|
||||||
/// For safety checks in debug builds only.
|
|
||||||
pub fn is_mutably_borrowed(&self) -> bool {
|
|
||||||
self.value.borrow_state() == BorrowState::Writing
|
|
||||||
}
|
|
||||||
|
|
||||||
/// Attempts to immutably borrow the wrapped value.
|
|
||||||
///
|
|
||||||
/// The borrow lasts until the returned `Ref` exits scope. Multiple
|
|
||||||
/// immutable borrows can be taken out at the same time.
|
|
||||||
///
|
|
||||||
/// Returns `None` if the value is currently mutably borrowed.
|
|
||||||
///
|
|
||||||
/// # Panics
|
|
||||||
///
|
|
||||||
/// Panics if this is called off the script thread.
|
|
||||||
pub fn try_borrow(&self) -> Option<Ref<T>> {
|
|
||||||
debug_assert!(thread_state::get().is_script());
|
|
||||||
match self.value.borrow_state() {
|
|
||||||
BorrowState::Writing => None,
|
|
||||||
_ => Some(self.value.borrow()),
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
/// Mutably borrows the wrapped value.
|
|
||||||
///
|
|
||||||
/// The borrow lasts until the returned `RefMut` exits scope. The value
|
|
||||||
/// cannot be borrowed while this borrow is active.
|
|
||||||
///
|
|
||||||
/// Returns `None` if the value is currently borrowed.
|
|
||||||
///
|
|
||||||
/// # Panics
|
|
||||||
///
|
|
||||||
/// Panics if this is called off the script thread.
|
|
||||||
pub fn try_borrow_mut(&self) -> Option<RefMut<T>> {
|
|
||||||
debug_assert!(thread_state::get().is_script());
|
|
||||||
match self.value.borrow_state() {
|
|
||||||
BorrowState::Unused => Some(self.value.borrow_mut()),
|
|
||||||
_ => None,
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
/// Version of the above that we use during restyle while the script thread
|
/// Version of the above that we use during restyle while the script thread
|
||||||
/// is blocked.
|
/// is blocked.
|
||||||
pub fn borrow_mut_for_layout(&self) -> RefMut<T> {
|
pub fn borrow_mut_for_layout(&self) -> RefMut<T> {
|
||||||
|
@ -149,4 +106,34 @@ impl<T> DOMRefCell<T> {
|
||||||
pub fn borrow_mut(&self) -> RefMut<T> {
|
pub fn borrow_mut(&self) -> RefMut<T> {
|
||||||
self.try_borrow_mut().expect("DOMRefCell<T> already borrowed")
|
self.try_borrow_mut().expect("DOMRefCell<T> already borrowed")
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// Attempts to immutably borrow the wrapped value.
|
||||||
|
///
|
||||||
|
/// The borrow lasts until the returned `Ref` exits scope. Multiple
|
||||||
|
/// immutable borrows can be taken out at the same time.
|
||||||
|
///
|
||||||
|
/// Returns `None` if the value is currently mutably borrowed.
|
||||||
|
///
|
||||||
|
/// # Panics
|
||||||
|
///
|
||||||
|
/// Panics if this is called off the script thread.
|
||||||
|
pub fn try_borrow(&self) -> Result<Ref<T>, BorrowError<T>> {
|
||||||
|
debug_assert!(thread_state::get().is_script());
|
||||||
|
self.value.try_borrow()
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Mutably borrows the wrapped value.
|
||||||
|
///
|
||||||
|
/// The borrow lasts until the returned `RefMut` exits scope. The value
|
||||||
|
/// cannot be borrowed while this borrow is active.
|
||||||
|
///
|
||||||
|
/// Returns `None` if the value is currently borrowed.
|
||||||
|
///
|
||||||
|
/// # Panics
|
||||||
|
///
|
||||||
|
/// Panics if this is called off the script thread.
|
||||||
|
pub fn try_borrow_mut(&self) -> Result<RefMut<T>, BorrowMutError<T>> {
|
||||||
|
debug_assert!(thread_state::get().is_script());
|
||||||
|
self.value.try_borrow_mut()
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
|
@ -3,7 +3,6 @@
|
||||||
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
||||||
|
|
||||||
#![feature(as_unsafe_cell)]
|
#![feature(as_unsafe_cell)]
|
||||||
#![feature(borrow_state)]
|
|
||||||
#![feature(box_syntax)]
|
#![feature(box_syntax)]
|
||||||
#![feature(conservative_impl_trait)]
|
#![feature(conservative_impl_trait)]
|
||||||
#![feature(const_fn)]
|
#![feature(const_fn)]
|
||||||
|
@ -19,6 +18,7 @@
|
||||||
#![feature(slice_patterns)]
|
#![feature(slice_patterns)]
|
||||||
#![feature(stmt_expr_attributes)]
|
#![feature(stmt_expr_attributes)]
|
||||||
#![feature(question_mark)]
|
#![feature(question_mark)]
|
||||||
|
#![feature(try_borrow)]
|
||||||
#![feature(try_from)]
|
#![feature(try_from)]
|
||||||
|
|
||||||
#![deny(unsafe_code)]
|
#![deny(unsafe_code)]
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue