Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-23 07:13:52 +01:00
Code Issues Projects Releases Packages Wiki Activity

Removed tidy-test errors

Browse source
This commit is contained in:
jaymodi98 2019-12-03 18:31:16 -05:00
parent 2108a85764
commit 2ee6150990
1 changed files with 27 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

41
components/script/dom/htmlformelement.rs
View file

@ -256,18 +256,18 @@ impl HTMLFormElementMethods for HTMLFormElement {
elements.IndexedGetter(index) elements.IndexedGetter(index)
} }
// https://html.spec.whatwg.org/multipage/#the-form-element%3Adetermine-the-value-of-a-named-property
fn NamedGetter(&self, name: DOMString) -> Option<RadioNodeListOrElement> { fn NamedGetter(&self, name: DOMString) -> Option<RadioNodeListOrElement> {
// return Option::Some::<RadioNodeListOrElement>; // return Option::Some::<RadioNodeListOrElement>;
unimplemented!(); unimplemented!();
} }
// https://html.spec.whatwg.org/multipage/forms.html#the-form-element:supported-property-names // https://html.spec.whatwg.org/multipage/#the-form-element:supported-property-names
fn SupportedPropertyNames(&self) -> Vec<DOMString> { fn SupportedPropertyNames(&self) -> Vec<DOMString> {
enum SourcedNameSource { enum SourcedNameSource {
Id, Id,
Name, Name,
Past(std::time::Duration) Past(std::time::Duration),
} }
struct SourcedName { struct SourcedName {
@ -285,16 +285,23 @@ impl HTMLFormElementMethods for HTMLFormElement {
// controls - list of form elements // controls - list of form elements
// check all listed elements first, push to sourcedNamesVec as per spec // check all listed elements first, push to sourcedNamesVec as per spec
for child in controls.iter() { for child in controls.iter() {
if child.is_html_element() {
if child.is_html_element() { // if child.is_listed() // if child.is_listed()
if child.has_attribute(&local_name!("id")) { if child.has_attribute(&local_name!("id")) {
// https://learning-rust.github.io/docs/b2.structs.html // https://learning-rust.github.io/docs/b2.structs.html
let entry = SourcedName {name: child.get_string_attribute(&local_name!("id")), element: child.root_element(), source: SourcedNameSource::Id}; let entry = SourcedName {
name: child.get_string_attribute(&local_name!("id")),
element: child.root_element(),
source: SourcedNameSource::Id,
};
sourcedNamesVec.push(entry); sourcedNamesVec.push(entry);
} } else if child.has_attribute(&local_name!("name")) {
else if child.has_attribute(&local_name!("name")) { let entry = SourcedName {
let entry = SourcedName {name: child.get_string_attribute(&local_name!("name")), element: child.root_element(), source: SourcedNameSource::Name}; name: child.get_string_attribute(&local_name!("name")),
element: child.root_element(),
source: SourcedNameSource::Name,
};
sourcedNamesVec.push(entry); sourcedNamesVec.push(entry);
} }
} }
@ -307,14 +314,20 @@ impl HTMLFormElementMethods for HTMLFormElement {
// https://users.rust-lang.org/t/how-check-type-of-variable/33845/7 // https://users.rust-lang.org/t/how-check-type-of-variable/33845/7
if child.is::<HTMLImageElement>() { if child.is::<HTMLImageElement>() {
if child.has_attribute(&local_name!("id")) { if child.has_attribute(&local_name!("id")) {
// https://learning-rust.github.io/docs/b2.structs.html // https://learning-rust.github.io/docs/b2.structs.html
let entry = SourcedName {name: child.get_string_attribute(&local_name!("id")), element: child.root_element(), source: SourcedNameSource::Id}; let entry = SourcedName {
name: child.get_string_attribute(&local_name!("id")),
element: child.root_element(),
source: SourcedNameSource::Id,
};
sourcedNamesVec.push(entry); sourcedNamesVec.push(entry);
} } else if child.has_attribute(&local_name!("name")) {
else if child.has_attribute(&local_name!("name")) { let entry = SourcedName {
let entry = SourcedName {name: child.get_string_attribute(&local_name!("name")), element: child.root_element(), source: SourcedNameSource::Name}; name: child.get_string_attribute(&local_name!("name")),
element: child.root_element(),
source: SourcedNameSource::Name,
};
sourcedNamesVec.push(entry); sourcedNamesVec.push(entry);
} }
} }