Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 06:00:15 +01:00
Code Issues Projects Releases Packages Wiki Activity

style: Remove Stylist::might_have_state_dependency.

Browse source 
We always know for sure whether we have a dependency on particular
event state bits, so just use has_state_dependency.
This commit is contained in:
Cameron McCormack 2017-10-05 09:43:57 +08:00
parent 21926e0008
commit 2f21070701
2 changed files with 2 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

6
components/style/stylist.rs
View file

@ -625,12 +625,6 @@ impl Stylist {
} }
} }
/// Returns whether the given ElementState bit might be relied upon by a
/// selector of some rule in the stylist.
pub fn might_have_state_dependency(&self, state: ElementState) -> bool {
self.has_state_dependency(state)
}
/// Returns whether the given ElementState bit is relied upon by a selector /// Returns whether the given ElementState bit is relied upon by a selector
/// of some rule in the stylist. /// of some rule in the stylist.
pub fn has_state_dependency(&self, state: ElementState) -> bool { pub fn has_state_dependency(&self, state: ElementState) -> bool {

4
ports/geckolib/glue.rs
View file

@ -4090,13 +4090,13 @@ pub extern "C" fn Servo_StyleSet_HasStateDependency(
let state = ElementState::from_bits_truncate(state); let state = ElementState::from_bits_truncate(state);
let data = PerDocumentStyleData::from_ffi(raw_data).borrow(); let data = PerDocumentStyleData::from_ffi(raw_data).borrow();
let mut has_dep = data.stylist.might_have_state_dependency(state); let mut has_dep = data.stylist.has_state_dependency(state);
if !has_dep { if !has_dep {
// TODO(emilio): Consider optimizing this storing attribute // TODO(emilio): Consider optimizing this storing attribute
// dependencies from UA sheets separately, so we could optimize // dependencies from UA sheets separately, so we could optimize
// the above lookup if cut_off_inheritance is true. // the above lookup if cut_off_inheritance is true.
element.each_xbl_stylist(|stylist| { element.each_xbl_stylist(|stylist| {
has_dep = has_dep || stylist.might_have_state_dependency(state); has_dep = has_dep || stylist.has_state_dependency(state);
}); });
} }