Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 14:10:11 +01:00
Code Issues Projects Releases Packages Wiki Activity

style: Rename ScrollSnapType to ScrollSnapStrictness.

Browse source 
The scroll snap strictness is defined in the new spec [1], and the structure
is the exactly same as the old scroll snap type structure.

[1] https://drafts.csswg.org/css-scroll-snap-1/#snap-strictness

Differential Revision: https://phabricator.services.mozilla.com/D21621
This commit is contained in:
Hiroyuki Ikezoe 2019-04-11 06:19:13 +00:00 • committed by Emilio Cobos Álvarez
parent 0a84073767
commit 2f457ed144
6 changed files with 8 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
components/style/properties/data.py
View file

@ -341,7 +341,7 @@ class Longhand(object):
"SVGOpacity", "SVGOpacity",
"SVGPaintOrder", "SVGPaintOrder",
"ScrollSnapAlign", "ScrollSnapAlign",
"ScrollSnapType", "ScrollSnapStrictness",
"TextAlign", "TextAlign",
"TextDecorationLine", "TextDecorationLine",
"TextEmphasisPosition", "TextEmphasisPosition",

4
components/style/properties/longhands/box.mako.rs
View file

@ -430,8 +430,8 @@ ${helpers.predefined_type(
% for axis in ["x", "y"]: % for axis in ["x", "y"]:
${helpers.predefined_type( ${helpers.predefined_type(
"scroll-snap-type-" + axis, "scroll-snap-type-" + axis,
"ScrollSnapType", "ScrollSnapStrictness",
"computed::ScrollSnapType::None", "computed::ScrollSnapStrictness::None",
products="gecko", products="gecko",
needs_context=False, needs_context=False,
gecko_pref="layout.css.scroll-snap.enabled", gecko_pref="layout.css.scroll-snap.enabled",

2
components/style/values/computed/box.rs
View file

@ -15,7 +15,7 @@ pub use crate::values::specified::box_::{AnimationName, Appearance, BreakBetween
pub use crate::values::specified::box_::{Clear as SpecifiedClear, Float as SpecifiedFloat}; pub use crate::values::specified::box_::{Clear as SpecifiedClear, Float as SpecifiedFloat};
pub use crate::values::specified::box_::{Contain, Display, Overflow}; pub use crate::values::specified::box_::{Contain, Display, Overflow};
pub use crate::values::specified::box_::{OverflowAnchor, OverflowClipBox}; pub use crate::values::specified::box_::{OverflowAnchor, OverflowClipBox};
pub use crate::values::specified::box_::{OverscrollBehavior, ScrollSnapAlign, ScrollSnapType}; pub use crate::values::specified::box_::{OverscrollBehavior, ScrollSnapAlign, ScrollSnapStrictness};
pub use crate::values::specified::box_::{TouchAction, TransitionProperty, WillChange}; pub use crate::values::specified::box_::{TouchAction, TransitionProperty, WillChange};
/// A computed value for the `vertical-align` property. /// A computed value for the `vertical-align` property.

2
components/style/values/computed/mod.rs
View file

@ -42,7 +42,7 @@ pub use self::box_::{AnimationIterationCount, AnimationName, Contain};
pub use self::box_::{Appearance, BreakBetween, BreakWithin, Clear, Float}; pub use self::box_::{Appearance, BreakBetween, BreakWithin, Clear, Float};
pub use self::box_::{Display, Overflow, OverflowAnchor, TransitionProperty}; pub use self::box_::{Display, Overflow, OverflowAnchor, TransitionProperty};
pub use self::box_::{OverflowClipBox, OverscrollBehavior, Perspective, Resize}; pub use self::box_::{OverflowClipBox, OverscrollBehavior, Perspective, Resize};
pub use self::box_::{ScrollSnapAlign, ScrollSnapType, TouchAction, VerticalAlign, WillChange}; pub use self::box_::{ScrollSnapAlign, ScrollSnapStrictness, TouchAction, VerticalAlign, WillChange};
pub use self::color::{Color, ColorOrAuto, ColorPropertyValue}; pub use self::color::{Color, ColorOrAuto, ColorPropertyValue};
pub use self::column::ColumnCount; pub use self::column::ColumnCount;
pub use self::counters::{Content, ContentItem, CounterIncrement, CounterSetOrReset}; pub use self::counters::{Content, ContentItem, CounterIncrement, CounterSetOrReset};

3
components/style/values/specified/box.rs
View file

@ -379,6 +379,7 @@ impl Parse for AnimationName {
} }
} }
/// https://drafts.csswg.org/css-scroll-snap-1/#snap-strictness
#[allow(missing_docs)] #[allow(missing_docs)]
#[cfg_attr(feature = "servo", derive(Deserialize, Serialize))] #[cfg_attr(feature = "servo", derive(Deserialize, Serialize))]
#[derive( #[derive(
@ -396,7 +397,7 @@ impl Parse for AnimationName {
ToShmem, ToShmem,
)] )]
#[repr(u8)] #[repr(u8)]
pub enum ScrollSnapType { pub enum ScrollSnapStrictness {
None, None,
Mandatory, Mandatory,
Proximity, Proximity,

2
components/style/values/specified/mod.rs
View file

@ -40,7 +40,7 @@ pub use self::box_::{AnimationIterationCount, AnimationName, Contain, Display};
pub use self::box_::{Appearance, BreakBetween, BreakWithin}; pub use self::box_::{Appearance, BreakBetween, BreakWithin};
pub use self::box_::{Clear, Float, Overflow, OverflowAnchor}; pub use self::box_::{Clear, Float, Overflow, OverflowAnchor};
pub use self::box_::{OverflowClipBox, OverscrollBehavior, Perspective, Resize}; pub use self::box_::{OverflowClipBox, OverscrollBehavior, Perspective, Resize};
pub use self::box_::{ScrollSnapAlign, ScrollSnapType}; pub use self::box_::{ScrollSnapAlign, ScrollSnapStrictness};
pub use self::box_::{TouchAction, TransitionProperty, VerticalAlign, WillChange}; pub use self::box_::{TouchAction, TransitionProperty, VerticalAlign, WillChange};
pub use self::color::{Color, ColorOrAuto, ColorPropertyValue}; pub use self::color::{Color, ColorOrAuto, ColorPropertyValue};
pub use self::column::ColumnCount; pub use self::column::ColumnCount;