diff --git a/components/script/canvas_state.rs b/components/script/canvas_state.rs index 2956a8ce86c..5730d9a8f1f 100644 --- a/components/script/canvas_state.rs +++ b/components/script/canvas_state.rs @@ -1207,7 +1207,7 @@ impl CanvasState { if sw == 0 || sh == 0 { return Err(Error::IndexSize); } - ImageData::new(global, sw.abs() as u32, sh.abs() as u32, None) + ImageData::new(global, sw.unsigned_abs(), sh.unsigned_abs(), None) } // https://html.spec.whatwg.org/multipage/#dom-context-2d-createimagedata diff --git a/components/script/dom/htmlinputelement.rs b/components/script/dom/htmlinputelement.rs index 53fc8b3574b..b00d2079db6 100755 --- a/components/script/dom/htmlinputelement.rs +++ b/components/script/dom/htmlinputelement.rs @@ -2863,7 +2863,7 @@ impl Activatable for HTMLInputElement { fn filter_from_accept(s: &DOMString) -> Vec { let mut filter = vec![]; for p in split_commas(s) { - if let Some('.') = p.chars().nth(0) { + if let Some('.') = p.chars().next() { filter.push(FilterPattern(p[1..].to_string())); } else if let Some(exts) = mime_guess::get_mime_extensions_str(p) { for ext in exts { diff --git a/components/script/dom/response.rs b/components/script/dom/response.rs index c199216c53c..f79472a9f71 100644 --- a/components/script/dom/response.rs +++ b/components/script/dom/response.rs @@ -299,7 +299,7 @@ impl ResponseMethods for Response { match *self.status.borrow() { Some(s) => { let status_num = s.as_u16(); - status_num >= 200 && status_num <= 299 + (200..=299).contains(&status_num) }, None => false, } diff --git a/components/script/dom/serviceworkerglobalscope.rs b/components/script/dom/serviceworkerglobalscope.rs index dbf792f62a0..69eca7f3b50 100644 --- a/components/script/dom/serviceworkerglobalscope.rs +++ b/components/script/dom/serviceworkerglobalscope.rs @@ -480,7 +480,7 @@ impl ServiceWorkerGlobalScope { fn dispatch_activate(&self) { let event = ExtendableEvent::new(self, atom!("activate"), false, false); - let event = (&*event).upcast::(); + let event = (*event).upcast::(); self.upcast::().dispatch_event(event); } } diff --git a/components/script/dom/stylepropertymapreadonly.rs b/components/script/dom/stylepropertymapreadonly.rs index 91c44ed5409..78aaeede4a3 100644 --- a/components/script/dom/stylepropertymapreadonly.rs +++ b/components/script/dom/stylepropertymapreadonly.rs @@ -92,7 +92,7 @@ impl StylePropertyMapReadOnlyMethods for StylePropertyMapReadOnly { } else { Ordering::Greater } - } else if let Ok(_) = custom_properties::parse_name(key2) { + } else if custom_properties::parse_name(key2).is_ok() { Ordering::Less } else { key1.cmp(key2) diff --git a/components/script/dom/xmlhttprequest.rs b/components/script/dom/xmlhttprequest.rs index 528e531c496..f9ba44d560f 100644 --- a/components/script/dom/xmlhttprequest.rs +++ b/components/script/dom/xmlhttprequest.rs @@ -1334,7 +1334,7 @@ impl XMLHttpRequest { let mime = self .final_mime_type() .as_ref() - .map(|m| normalize_type_string(&m.to_string())) + .map(|m| normalize_type_string(m.as_ref())) .unwrap_or("".to_owned()); // Step 3, 4 diff --git a/components/script/script_module.rs b/components/script/script_module.rs index aa1d6ed35dd..062a0b5ec99 100644 --- a/components/script/script_module.rs +++ b/components/script/script_module.rs @@ -1110,7 +1110,7 @@ impl FetchResponseListener for ModuleContext { } else { return Err(NetworkError::Internal(format!( "Failed to parse MIME type: {}", - content_type.to_string() + content_type ))); } } else {