mirror of
https://github.com/servo/servo.git
synced 2025-10-01 09:09:15 +01:00
Auto merge of #12703 - sjmelia:12343_test_activation, r=Manishearth
Fix Issue 12343: Add pref-gated methods and test for activatable element <!-- Please describe your changes on the following line: --> Add methods to activatable elements; gated by a preference, for use in servo-specific WPT tests. I cargo-culted over the "redundant check" from #12322, I don't really understand the possible exploit. Obvious flaw is the copypasta for each element. I understand that the webidl codegen will produce a trait for ActivatableElement, but I can't see how I can provide a default implementation for this? I guess otherwise could be an improvement to have each element just delegate to an Enter.../Exit... method on the Activatable trait? --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #12343 (github issue number if applicable). <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> …states <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12703) <!-- Reviewable:end -->
This commit is contained in:
commit
2fb4dd9ec3
6 changed files with 98 additions and 0 deletions
|
@ -6510,6 +6510,12 @@
|
|||
"url": "/_mozilla/mozilla/MouseEvent.html"
|
||||
}
|
||||
],
|
||||
"mozilla/activation.html": [
|
||||
{
|
||||
"path": "mozilla/activation.html",
|
||||
"url": "/_mozilla/mozilla/activation.html"
|
||||
}
|
||||
],
|
||||
"mozilla/bad_cert_detected.html": [
|
||||
{
|
||||
"path": "mozilla/bad_cert_detected.html",
|
||||
|
|
3
tests/wpt/mozilla/meta/mozilla/activation.html.ini
Normal file
3
tests/wpt/mozilla/meta/mozilla/activation.html.ini
Normal file
|
@ -0,0 +1,3 @@
|
|||
[activation.html]
|
||||
type: testharness
|
||||
prefs: [dom.testing.element.activation.enabled:true]
|
Loading…
Add table
Add a link
Reference in a new issue