Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 04:30:10 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fix geometry queries for floats and replaced inlines (#34083)

Browse source 
APIs like `clientWidth` were returning zero.

Signed-off-by: Oriol Brufau <obrufau@igalia.com>
This commit is contained in:
Oriol Brufau 2024-10-31 15:44:15 +01:00 • committed by GitHub
parent 62c7951424
commit 31566aef02
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
101 changed files with 5 additions and 2303 deletions
Download patch file Download diff file Expand all files Collapse all files

7
components/layout_2020/fragment_tree/fragment_tree.rs
View file

@ -16,6 +16,7 @@ use super::{ContainingBlockManager, Fragment, Tag};
use crate::cell::ArcRefCell;
use crate::display_list::StackingContext;
use crate::flow::CanvasBackground;
use crate::fragment_tree::FragmentFlags;
use crate::geom::PhysicalRect;
#[derive(Serialize)]
@ -134,13 +135,15 @@ impl FragmentTree {
}
let rect = match fragment {
Fragment::Box(fragment) => {
Fragment::Box(fragment) | Fragment::Float(fragment) => {
// https://drafts.csswg.org/cssom-view/#dom-element-clienttop
// " If the element has no associated CSS layout box or if the
// CSS layout box is inline, return zero." For this check we
// also explicitly ignore the list item portion of the display
// style.
if fragment.style.get_box().display.is_inline_flow() {
if fragment.style.get_box().display.is_inline_flow() &&
!fragment.base.flags.contains(FragmentFlags::IS_REPLACED)
{
return Some(Rect::zero());
}