From 31838b1e6f759113cf432d24ff9268919cf368ca Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Emilio=20Cobos=20=C3=81lvarez?= Date: Sat, 15 Dec 2018 22:48:37 +0000 Subject: [PATCH] style: The 'all' property is not animatable. Since it allows to animate display, which is not good. This is a regression from: https://hg.mozilla.org/mozilla-central/rev/6884ba750aa3 Actually I wonder if the logic shouldn't be the other way around, i.e., a shorthand is animatable if all the longhands are, not if just one. In any case this rolls back to the previous behavior, should we do that, it should be another bug. Differential Revision: https://phabricator.services.mozilla.com/D14632 --- components/style/properties/data.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/components/style/properties/data.py b/components/style/properties/data.py index 8faaa163823..4d980039d1e 100644 --- a/components/style/properties/data.py +++ b/components/style/properties/data.py @@ -388,12 +388,12 @@ class Shorthand(object): and allowed_in_keyframe_block != "False" def get_animatable(self): - animatable = False + if self.ident == "all": + return False for sub in self.sub_properties: if sub.animatable: - animatable = True - break - return animatable + return True + return False def get_transitionable(self): transitionable = False