Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 20:50:07 +01:00
Code Issues Projects Releases Packages Wiki Activity

Return KeyReaction::Nothing for a Tab event

Browse source 
Hitting the tab key in an html text input shouldn't submit the form, and
for any text input, the tab key should have a particular action
associated, not the default action. This cleans up #12701.
This commit is contained in:
Jean-Marie Comets 2016-11-12 15:49:00 +01:00
parent 2d0c7166f1
commit 319153640c
2 changed files with 4 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

17
components/script/dom/htmlinputelement.rs
View file

@ -35,7 +35,6 @@ use dom::virtualmethods::VirtualMethods;
use html5ever_atoms::LocalName; use html5ever_atoms::LocalName;
use ipc_channel::ipc::{self, IpcSender}; use ipc_channel::ipc::{self, IpcSender};
use mime_guess; use mime_guess;
use msg::constellation_msg::Key;
use net_traits::{CoreResourceMsg, IpcSend}; use net_traits::{CoreResourceMsg, IpcSend};
use net_traits::blob_url_store::get_blob_origin; use net_traits::blob_url_store::get_blob_origin;
use net_traits::filemanager_thread::{FileManagerThreadMsg, FilterPattern}; use net_traits::filemanager_thread::{FileManagerThreadMsg, FilterPattern};
@ -1097,18 +1096,10 @@ impl VirtualMethods for HTMLInputElement {
let action = self.textinput.borrow_mut().handle_keydown(keyevent); let action = self.textinput.borrow_mut().handle_keydown(keyevent);
match action { match action {
TriggerDefaultAction => { TriggerDefaultAction => {
if let Some(key) = keyevent.get_key() { self.implicit_submission(keyevent.CtrlKey(),
match key { keyevent.ShiftKey(),
Key::Enter | Key::KpEnter => keyevent.AltKey(),
self.implicit_submission(keyevent.CtrlKey(), keyevent.MetaKey());
keyevent.ShiftKey(),
keyevent.AltKey(),
keyevent.MetaKey()),
// Issue #12071: Tab should not submit forms
// TODO(3982): Implement form keyboard navigation
_ => (),
}
};
}, },
DispatchInput => { DispatchInput => {
self.value_changed.set(true); self.value_changed.set(true);

1
components/script/textinput.rs
View file

@ -544,7 +544,6 @@ impl<T: ClipboardProvider> TextInput<T> {
self.adjust_vertical(28, maybe_select); self.adjust_vertical(28, maybe_select);
KeyReaction::RedrawSelection KeyReaction::RedrawSelection
} }
(None, Key::Tab) => KeyReaction::TriggerDefaultAction,
_ => KeyReaction::Nothing, _ => KeyReaction::Nothing,
} }
} }