Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-24 07:40:27 +01:00
Code Issues Projects Releases Packages Wiki Activity

s/nodes_from_point/nodes_from_point_response and change test from reftest to regular test checking only the fixed crash

Browse source
This commit is contained in:
Fernando Jiménez Moreno 2017-03-02 16:51:42 +01:00
parent 7426d902a3
commit 31d833f32c
6 changed files with 17 additions and 32 deletions
Download patch file Download diff file Expand all files Collapse all files

2
components/layout/query.rs
View file

@ -147,7 +147,7 @@ impl LayoutRPC for LayoutRPCImpl {
} }
} }
fn nodes_from_point(&self) -> Vec<UntrustedNodeAddress> { fn nodes_from_point_response(&self) -> Vec<UntrustedNodeAddress> {
let &LayoutRPCImpl(ref rw_data) = self; let &LayoutRPCImpl(ref rw_data) = self;
let rw_data = rw_data.lock().unwrap(); let rw_data = rw_data.lock().unwrap();
rw_data.nodes_from_point_response.clone() rw_data.nodes_from_point_response.clone()

2
components/script/dom/document.rs
View file

@ -1883,7 +1883,7 @@ impl Document {
return vec!(); return vec!();
}; };
self.window.layout().nodes_from_point() self.window.layout().nodes_from_point_response()
} }
} }

2
components/script_layout_interface/rpc.rs
View file

@ -41,7 +41,7 @@ pub trait LayoutRPC {
/// Requests the list of not-yet-loaded images that were encountered in the last reflow. /// Requests the list of not-yet-loaded images that were encountered in the last reflow.
fn pending_images(&self) -> Vec<PendingImage>; fn pending_images(&self) -> Vec<PendingImage>;
/// Requests the list of nodes from the given point. /// Requests the list of nodes from the given point.
fn nodes_from_point(&self) -> Vec<UntrustedNodeAddress>; fn nodes_from_point_response(&self) -> Vec<UntrustedNodeAddress>;
fn text_index(&self) -> TextIndexResponse; fn text_index(&self) -> TextIndexResponse;
} }

31
tests/wpt/mozilla/meta/MANIFEST.json
View file

@ -6341,18 +6341,6 @@
{} {}
] ]
], ],
"mozilla/document_elementsFromPoint.html": [
[
"/_mozilla/mozilla/document_elementsFromPoint.html",
[
[
"/_mozilla/mozilla/document_elementsFromPoint_ref.html",
"=="
]
],
{}
]
],
"mozilla/iframe/resize_after_load.html": [ "mozilla/iframe/resize_after_load.html": [
[ [
"/_mozilla/mozilla/iframe/resize_after_load.html", "/_mozilla/mozilla/iframe/resize_after_load.html",
@ -9400,11 +9388,6 @@
{} {}
] ]
], ],
"mozilla/document_elementsFromPoint_ref.html": [
[
{}
]
],
"mozilla/form_submit_about_frame.html": [ "mozilla/form_submit_about_frame.html": [
[ [
{} {}
@ -12615,6 +12598,12 @@
{} {}
] ]
], ],
"mozilla/document_elementsFromPoint.html": [
[
"/_mozilla/mozilla/document_elementsFromPoint.html",
{}
]
],
"mozilla/document_getElementById.html": [ "mozilla/document_getElementById.html": [
[ [
"/_mozilla/mozilla/document_getElementById.html", "/_mozilla/mozilla/document_getElementById.html",
@ -25155,12 +25144,8 @@
"testharness" "testharness"
], ],
"mozilla/document_elementsFromPoint.html": [ "mozilla/document_elementsFromPoint.html": [
"2349e1d102552a46bb8e3dd36c0b3396e0d6530b", "00da2141b1143619351c6fbb66d677ca9002a4a8",
"reftest" "testharness"
],
"mozilla/document_elementsFromPoint_ref.html": [
"4d1a1d0acc16bcb123781cbed47184ff308f3097",
"support"
], ],
"mozilla/document_getElementById.html": [ "mozilla/document_getElementById.html": [
"ae5270afde878c8fbe9b4a89c5c3f8ff609220dc", "ae5270afde878c8fbe9b4a89c5c3f8ff609220dc",

9
tests/wpt/mozilla/tests/mozilla/document_elementsFromPoint.html
View file

@ -1,7 +1,10 @@
<!doctype html> <!doctype html>
<meta charset="utf-8"> <meta charset="utf-8">
<title></title> <title>document.elementsFromPoint does not crash due to a missing display list</title>
<link rel="match" href="document_elementsFromPoint_ref.html"> <script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script> <script>
var elements = document.elementsFromPoint(10, 10); test(function() {
document.elementsFromPoint(10, 10);
}, "doesn't crash");
</script> </script>

3
tests/wpt/mozilla/tests/mozilla/document_elementsFromPoint_ref.html
View file

@ -1,3 +0,0 @@
<!doctype html>
<meta charset="utf-8">
<title></title>