Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 21:50:18 +01:00
Code Issues Projects Releases Packages Wiki Activity

return null from GetNamespaceURI, not the empty string

Browse source 
correctly mark tests
This commit is contained in:
Rohan Prinja 2014-08-25 23:16:01 +05:30
parent 782deca569
commit 32b7f5e136
3 changed files with 6 additions and 41 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/components/script/dom/element.rs
View file

@ -471,8 +471,11 @@ impl Element {
impl<'a> ElementMethods for JSRef<'a, Element> { impl<'a> ElementMethods for JSRef<'a, Element> {
// http://dom.spec.whatwg.org/#dom-element-namespaceuri // http://dom.spec.whatwg.org/#dom-element-namespaceuri
fn NamespaceURI(&self) -> DOMString { fn GetNamespaceURI(&self) -> Option<DOMString> {
self.namespace.to_str().to_string() match self.namespace {
Null => None,
ref ns => Some(ns.to_str().to_string())
}
} }
fn LocalName(&self) -> DOMString { fn LocalName(&self) -> DOMString {

2
src/components/script/dom/webidls/Element.webidl
View file

@ -19,7 +19,7 @@ interface Element : Node {
readonly attribute DOMString localName; readonly attribute DOMString localName;
[Constant] [Constant]
readonly attribute DOMString namespaceURI; readonly attribute DOMString? namespaceURI;
// Not [Constant] because it depends on which document we're in // Not [Constant] because it depends on which document we're in
[Pure] [Pure]
readonly attribute DOMString tagName; readonly attribute DOMString tagName;

38
src/test/wpt/metadata/dom/nodes/DOMImplementation-createDocument.html.ini
View file

@ -1,47 +1,12 @@
[DOMImplementation-createDocument.html] [DOMImplementation-createDocument.html]
type: testharness type: testharness
[createDocument test 2: null,undefined,null,null]
expected: FAIL
[createDocument test 4: null,"foo",null,null]
expected: FAIL
[createDocument test 6: null,"f1oo",null,null]
expected: FAIL
[createDocument test 7: null,"foo1",null,null]
expected: FAIL
[createDocument test 11: null,"xml",null,null]
expected: FAIL
[createDocument test 12: null,"xmlns",null,"NAMESPACE_ERR"] [createDocument test 12: null,"xmlns",null,"NAMESPACE_ERR"]
expected: FAIL expected: FAIL
[createDocument test 13: null,"xmlfoo",null,null]
expected: FAIL
[createDocument test 18: undefined,undefined,undefined,null]
expected: FAIL
[createDocument test 20: undefined,"foo",undefined,null]
expected: FAIL
[createDocument test 22: undefined,"f1oo",undefined,null]
expected: FAIL
[createDocument test 23: undefined,"foo1",undefined,null]
expected: FAIL
[createDocument test 27: undefined,"xml",undefined,null]
expected: FAIL
[createDocument test 28: undefined,"xmlns",undefined,"NAMESPACE_ERR"] [createDocument test 28: undefined,"xmlns",undefined,"NAMESPACE_ERR"]
expected: FAIL expected: FAIL
[createDocument test 29: undefined,"xmlfoo",undefined,null]
expected: FAIL
[createDocument test 41: "http://example.com/","foo:",null,"NAMESPACE_ERR"] [createDocument test 41: "http://example.com/","foo:",null,"NAMESPACE_ERR"]
expected: FAIL expected: FAIL
@ -78,6 +43,3 @@
[createDocument test 106: "foo:","xmlns:foo",null,"NAMESPACE_ERR"] [createDocument test 106: "foo:","xmlns:foo",null,"NAMESPACE_ERR"]
expected: FAIL expected: FAIL
[createDocument test 113: null,"foo",DocumentType node,null]
expected: FAIL