From 32e5679175d845eeb244b9a05b9e275b30d347ba Mon Sep 17 00:00:00 2001 From: Matt Brubeck Date: Fri, 3 Apr 2015 12:02:33 -0700 Subject: [PATCH] `mach test-unit -p` should not build all tests This changes the `mach test-unit -p foo` command to build only the requested crate, not the entire `servo` crate. --- python/servo/testing_commands.py | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/python/servo/testing_commands.py b/python/servo/testing_commands.py index 299064d5a37..b64d0030d18 100644 --- a/python/servo/testing_commands.py +++ b/python/servo/testing_commands.py @@ -119,9 +119,6 @@ class MachCommands(CommandBase): package = component self.ensure_bootstrapped() - self.ensure_built_tests() - - ret = self.run_test("servo", test_name) != 0 def cargo_test(component): return 0 != subprocess.call( @@ -129,12 +126,13 @@ class MachCommands(CommandBase): + test_name, env=self.build_env(), cwd=self.servo_crate()) if package is not None: - ret = ret or cargo_test(package) - else: - for c in os.listdir("components"): - if c != "servo": - ret = ret or cargo_test(c) + return cargo_test(package) + self.ensure_built_tests() + ret = self.run_test("servo", test_name) != 0 + for c in os.listdir("components"): + if c != "servo": + ret = ret or cargo_test(c) return ret @Command('test-ref',