Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 13:40:08 +01:00
Code Issues Projects Releases Packages Wiki Activity

Implement cached Document.Links

Browse source
This commit is contained in:
Bruno de Oliveira Abinader 2014-08-14 10:06:52 -04:00
parent 984ec0e0c3
commit 330f72fba5
1 changed files with 15 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

25
src/components/script/dom/document.rs
View file

@ -78,6 +78,7 @@ pub struct Document {
pub is_html_document: bool, pub is_html_document: bool,
url: Untraceable<Url>, url: Untraceable<Url>,
quirks_mode: Untraceable<Cell<QuirksMode>>, quirks_mode: Untraceable<Cell<QuirksMode>>,
links: Cell<Option<JS<HTMLCollection>>>,
} }
impl DocumentDerived for EventTarget { impl DocumentDerived for EventTarget {
@ -86,6 +87,13 @@ impl DocumentDerived for EventTarget {
} }
} }
struct LinksFilter;
impl CollectionFilter for LinksFilter {
fn filter(&self, elem: &JSRef<Element>, _root: &JSRef<Node>) -> bool {
(elem.is_htmlanchorelement() || elem.is_htmlareaelement()) && elem.has_attribute("href")
}
}
pub trait DocumentHelpers { pub trait DocumentHelpers {
fn url<'a>(&'a self) -> &'a Url; fn url<'a>(&'a self) -> &'a Url;
fn quirks_mode(&self) -> QuirksMode; fn quirks_mode(&self) -> QuirksMode;
@ -228,6 +236,7 @@ impl Document {
// http://dom.spec.whatwg.org/#concept-document-encoding // http://dom.spec.whatwg.org/#concept-document-encoding
encoding_name: Traceable::new(RefCell::new("utf-8".to_string())), encoding_name: Traceable::new(RefCell::new("utf-8".to_string())),
is_html_document: is_html_document == HTMLDocument, is_html_document: is_html_document == HTMLDocument,
links: Cell::new(None),
} }
} }
@ -689,18 +698,14 @@ impl<'a> DocumentMethods for JSRef<'a, Document> {
} }
fn Links(&self) -> Temporary<HTMLCollection> { fn Links(&self) -> Temporary<HTMLCollection> {
let window = self.window.root();
// FIXME: https://github.com/mozilla/servo/issues/1847 // FIXME: https://github.com/mozilla/servo/issues/1847
struct LinksFilter; if self.links.get().is_none() {
impl CollectionFilter for LinksFilter { let window = self.window.root();
fn filter(&self, elem: &JSRef<Element>, _root: &JSRef<Node>) -> bool { let root = NodeCast::from_ref(self);
(elem.is_htmlanchorelement() || elem.is_htmlareaelement()) &&
elem.get_attribute(Null, "href").is_some()
}
}
let filter = box LinksFilter; let filter = box LinksFilter;
HTMLCollection::create(&*window, NodeCast::from_ref(self), filter) self.links.assign(Some(HTMLCollection::create(&*window, root, filter)));
}
Temporary::new(self.links.get().get_ref().clone())
} }
fn Forms(&self) -> Temporary<HTMLCollection> { fn Forms(&self) -> Temporary<HTMLCollection> {