Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-06-06 16:45:39 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fail gracefully when DMG smoketest fails (#30975)

Browse source 
It seems that timing issues (related to MacOS or the GitHub MacOS)
runners can sometimes cause `hdiutil detach` to fail. Instead of having
this cause the entire build to fail, fail gracefully. This is
essentially a non-issue as the CI environment is always cleaned up when
using GitHub Actions.

Fixes #30757.
This commit is contained in:
Martin Robinson 2024-01-02 17:11:16 +01:00 • committed by GitHub
parent bbadef3365
commit 3353db71d2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
.github/workflows/mac.yml vendored
View file

@ -111,7 +111,7 @@ jobs:
command: python3 ./mach test-unit --${{ inputs.profile }} command: python3 ./mach test-unit --${{ inputs.profile }}
- name: Build mach package - name: Build mach package
run: python3 ./mach package --${{ inputs.profile }} run: python3 ./mach package --${{ inputs.profile }}
- name: Run smoketest for mach package - name: Run DMG smoketest
uses: nick-fields/retry@v2 uses: nick-fields/retry@v2
with: # See https://github.com/servo/servo/issues/30757 with: # See https://github.com/servo/servo/issues/30757
timeout_minutes: 5 timeout_minutes: 5

5
etc/ci/macos_package_smoketest.sh
View file

@ -24,4 +24,7 @@ grep 'success' /tmp/out
# Clean up. # Clean up.
popd popd
hdiutil detach /Volumes/Servo
hdiutil detach /Volumes/Servo || \
echo "WARNING: Could not detach /Volumes/Servo. " \
"Please detach with hdiutil manually."