Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-06-06 16:45:39 +00:00
Code Issues Projects Releases Packages Wiki Activity

Add ReferrerPolicy IDL attribute to iframes (#34526)

Browse source 
Signed-off-by: Shane Handley <shanehandley@fastmail.com>
This commit is contained in:
shanehandley 2024-12-09 02:28:49 +11:00 • committed by GitHub
parent b3977e7f6c
commit 3363e1a261
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
10 changed files with 29 additions and 206 deletions
Download patch file Download diff file Expand all files Collapse all files

31
components/script/dom/htmliframeelement.rs
View file

@ -9,6 +9,7 @@ use bitflags::bitflags;
use dom_struct::dom_struct;
use html5ever::{local_name, namespace_url, ns, LocalName, Prefix};
use js::rust::HandleObject;
use net_traits::ReferrerPolicy;
use profile_traits::ipc as ProfiledIpc;
use script_traits::IFrameSandboxState::{IFrameSandboxed, IFrameUnsandboxed};
use script_traits::{
@ -29,9 +30,11 @@ use crate::dom::bindings::refcounted::Trusted;
use crate::dom::bindings::reflector::DomObject;
use crate::dom::bindings::root::{DomRoot, LayoutDom, MutNullableDom};
use crate::dom::bindings::str::{DOMString, USVString};
use crate::dom::document::Document;
use crate::dom::document::{determine_policy_for_token, Document};
use crate::dom::domtokenlist::DOMTokenList;
use crate::dom::element::{AttributeMutation, Element, LayoutElementHelpers};
use crate::dom::element::{
reflect_referrer_policy_attribute, AttributeMutation, Element, LayoutElementHelpers,
};
use crate::dom::eventtarget::EventTarget;
use crate::dom::globalscope::GlobalScope;
use crate::dom::htmlelement::HTMLElement;
@ -300,6 +303,19 @@ impl HTMLIFrameElement {
// > `element`.
let url = self.get_url();
// Step 2.4: Let referrerPolicy be the current state of element's referrerpolicy content
// attribute.
let document = document_from_node(self);
let referrer_policy_token = self.ReferrerPolicy();
// Note: despite not being explicitly stated in the spec steps, this falls back to
// document's referrer policy here because it satisfies the expectations that when unset,
// the iframe should inherit the referrer policy of its parent
let referrer_policy = match determine_policy_for_token(referrer_policy_token.str()) {
ReferrerPolicy::EmptyString => document.get_referrer_policy(),
policy => policy,
};
// TODO(#25748):
// By spec, we return early if there's an ancestor browsing context
// "whose active document's url, ignoring fragments, is equal".
@ -331,13 +347,12 @@ impl HTMLIFrameElement {
None
};
let document = document_from_node(self);
let load_data = LoadData::new(
LoadOrigin::Script(document.origin().immutable().clone()),
url,
creator_pipeline_id,
window.upcast::<GlobalScope>().get_referrer(),
document.get_referrer_policy(),
referrer_policy,
Some(window.upcast::<GlobalScope>().is_secure_context()),
);
@ -610,6 +625,14 @@ impl HTMLIFrameElementMethods<crate::DomTypeHolder> for HTMLIFrameElement {
Some(document)
}
/// <https://html.spec.whatwg.org/multipage/#attr-iframe-referrerpolicy>
fn ReferrerPolicy(&self) -> DOMString {
reflect_referrer_policy_attribute(self.upcast::<Element>())
}
// https://html.spec.whatwg.org/multipage/#attr-iframe-referrerpolicy
make_setter!(SetReferrerPolicy, "referrerpolicy");
// https://html.spec.whatwg.org/multipage/#attr-iframe-allowfullscreen
make_bool_getter!(AllowFullscreen, "allowfullscreen");
// https://html.spec.whatwg.org/multipage/#attr-iframe-allowfullscreen

2
components/script/dom/webidls/HTMLIFrameElement.webidl
View file

@ -23,6 +23,8 @@ interface HTMLIFrameElement : HTMLElement {
attribute boolean allowFullscreen;
[CEReactions]
attribute DOMString width;
[CEReactions]
attribute DOMString referrerPolicy;
[CEReactions]
attribute DOMString height;
readonly attribute Document? contentDocument;

6
tests/wpt/meta/html/dom/idlharness.https.html.ini vendored
View file

@ -6415,9 +6415,6 @@
[HTMLIFrameElement interface: attribute allow]
expected: FAIL
[HTMLIFrameElement interface: attribute referrerPolicy]
expected: FAIL
[HTMLIFrameElement interface: attribute loading]
expected: FAIL
@ -6445,9 +6442,6 @@
[HTMLIFrameElement interface: document.createElement("iframe") must inherit property "allow" with the proper type]
expected: FAIL
[HTMLIFrameElement interface: document.createElement("iframe") must inherit property "referrerPolicy" with the proper type]
expected: FAIL
[HTMLIFrameElement interface: document.createElement("iframe") must inherit property "loading" with the proper type]
expected: FAIL

37
tests/wpt/meta/referrer-policy/gen/req.attr/no-referrer/iframe-tag.http.html.ini vendored
View file

@ -1,37 +0,0 @@
[iframe-tag.http.html]
[Referrer Policy: Expects omitted for iframe-tag to same-https origin and keep-origin redirection from http context.]
expected: FAIL
[Referrer Policy: Expects omitted for iframe-tag to cross-http origin and keep-origin redirection from http context.]
expected: FAIL
[Referrer Policy: Expects omitted for iframe-tag to same-http origin and swap-origin redirection from http context.]
expected: FAIL
[Referrer Policy: Expects omitted for iframe-tag to same-https origin and no-redirect redirection from http context.]
expected: FAIL
[Referrer Policy: Expects omitted for iframe-tag to cross-http origin and swap-origin redirection from http context.]
expected: FAIL
[Referrer Policy: Expects omitted for iframe-tag to cross-http origin and no-redirect redirection from http context.]
expected: FAIL
[Referrer Policy: Expects omitted for iframe-tag to same-http origin and keep-origin redirection from http context.]
expected: FAIL
[Referrer Policy: Expects omitted for iframe-tag to cross-https origin and no-redirect redirection from http context.]
expected: FAIL
[Referrer Policy: Expects omitted for iframe-tag to cross-https origin and swap-origin redirection from http context.]
expected: FAIL
[Referrer Policy: Expects omitted for iframe-tag to same-https origin and swap-origin redirection from http context.]
expected: FAIL
[Referrer Policy: Expects omitted for iframe-tag to cross-https origin and keep-origin redirection from http context.]
expected: FAIL
[Referrer Policy: Expects omitted for iframe-tag to same-http origin and no-redirect redirection from http context.]
expected: FAIL

30
tests/wpt/meta/referrer-policy/gen/req.attr/origin-when-cross-origin/iframe-tag.http.html.ini vendored
View file

@ -1,30 +0,0 @@
[iframe-tag.http.html]
[Referrer Policy: Expects origin for iframe-tag to cross-http origin and keep-origin redirection from http context.]
expected: FAIL
[Referrer Policy: Expects origin for iframe-tag to cross-http origin and no-redirect redirection from http context.]
expected: FAIL
[Referrer Policy: Expects origin for iframe-tag to cross-http origin and swap-origin redirection from http context.]
expected: FAIL
[Referrer Policy: Expects origin for iframe-tag to cross-https origin and keep-origin redirection from http context.]
expected: FAIL
[Referrer Policy: Expects origin for iframe-tag to cross-https origin and no-redirect redirection from http context.]
expected: FAIL
[Referrer Policy: Expects origin for iframe-tag to cross-https origin and swap-origin redirection from http context.]
expected: FAIL
[Referrer Policy: Expects origin for iframe-tag to same-http origin and swap-origin redirection from http context.]
expected: FAIL
[Referrer Policy: Expects origin for iframe-tag to same-https origin and keep-origin redirection from http context.]
expected: FAIL
[Referrer Policy: Expects origin for iframe-tag to same-https origin and no-redirect redirection from http context.]
expected: FAIL
[Referrer Policy: Expects origin for iframe-tag to same-https origin and swap-origin redirection from http context.]
expected: FAIL

36
tests/wpt/meta/referrer-policy/gen/req.attr/origin/iframe-tag.http.html.ini vendored
View file

@ -1,36 +0,0 @@
[iframe-tag.http.html]
[Referrer Policy: Expects origin for iframe-tag to cross-http origin and keep-origin redirection from http context.]
expected: FAIL
[Referrer Policy: Expects origin for iframe-tag to cross-http origin and no-redirect redirection from http context.]
expected: FAIL
[Referrer Policy: Expects origin for iframe-tag to cross-http origin and swap-origin redirection from http context.]
expected: FAIL
[Referrer Policy: Expects origin for iframe-tag to cross-https origin and keep-origin redirection from http context.]
expected: FAIL
[Referrer Policy: Expects origin for iframe-tag to cross-https origin and no-redirect redirection from http context.]
expected: FAIL
[Referrer Policy: Expects origin for iframe-tag to cross-https origin and swap-origin redirection from http context.]
expected: FAIL
[Referrer Policy: Expects origin for iframe-tag to same-http origin and keep-origin redirection from http context.]
expected: FAIL
[Referrer Policy: Expects origin for iframe-tag to same-http origin and no-redirect redirection from http context.]
expected: FAIL
[Referrer Policy: Expects origin for iframe-tag to same-http origin and swap-origin redirection from http context.]
expected: FAIL
[Referrer Policy: Expects origin for iframe-tag to same-https origin and keep-origin redirection from http context.]
expected: FAIL
[Referrer Policy: Expects origin for iframe-tag to same-https origin and no-redirect redirection from http context.]
expected: FAIL
[Referrer Policy: Expects origin for iframe-tag to same-https origin and swap-origin redirection from http context.]
expected: FAIL

24
tests/wpt/meta/referrer-policy/gen/req.attr/same-origin/iframe-tag.http.html.ini vendored
View file

@ -1,24 +0,0 @@
[iframe-tag.http.html]
[Referrer Policy: Expects omitted for iframe-tag to cross-http origin and keep-origin redirection from http context.]
expected: FAIL
[Referrer Policy: Expects omitted for iframe-tag to cross-http origin and no-redirect redirection from http context.]
expected: FAIL
[Referrer Policy: Expects omitted for iframe-tag to cross-http origin and swap-origin redirection from http context.]
expected: FAIL
[Referrer Policy: Expects omitted for iframe-tag to cross-https origin and keep-origin redirection from http context.]
expected: FAIL
[Referrer Policy: Expects omitted for iframe-tag to cross-https origin and no-redirect redirection from http context.]
expected: FAIL
[Referrer Policy: Expects omitted for iframe-tag to cross-https origin and swap-origin redirection from http context.]
expected: FAIL
[Referrer Policy: Expects omitted for iframe-tag to same-http origin and swap-origin redirection from http context.]
expected: FAIL
[Referrer Policy: Expects omitted for iframe-tag to same-https origin and swap-origin redirection from http context.]
expected: FAIL

30
tests/wpt/meta/referrer-policy/gen/req.attr/strict-origin-when-cross-origin/iframe-tag.http.html.ini vendored
View file

@ -1,30 +0,0 @@
[iframe-tag.http.html]
[Referrer Policy: Expects origin for iframe-tag to cross-http origin and keep-origin redirection from http context.]
expected: FAIL
[Referrer Policy: Expects origin for iframe-tag to cross-http origin and no-redirect redirection from http context.]
expected: FAIL
[Referrer Policy: Expects origin for iframe-tag to cross-http origin and swap-origin redirection from http context.]
expected: FAIL
[Referrer Policy: Expects origin for iframe-tag to cross-https origin and keep-origin redirection from http context.]
expected: FAIL
[Referrer Policy: Expects origin for iframe-tag to cross-https origin and no-redirect redirection from http context.]
expected: FAIL
[Referrer Policy: Expects origin for iframe-tag to cross-https origin and swap-origin redirection from http context.]
expected: FAIL
[Referrer Policy: Expects origin for iframe-tag to same-http origin and swap-origin redirection from http context.]
expected: FAIL
[Referrer Policy: Expects origin for iframe-tag to same-https origin and keep-origin redirection from http context.]
expected: FAIL
[Referrer Policy: Expects origin for iframe-tag to same-https origin and no-redirect redirection from http context.]
expected: FAIL
[Referrer Policy: Expects origin for iframe-tag to same-https origin and swap-origin redirection from http context.]
expected: FAIL

36
tests/wpt/meta/referrer-policy/gen/req.attr/strict-origin/iframe-tag.http.html.ini vendored
View file

@ -1,36 +0,0 @@
[iframe-tag.http.html]
[Referrer Policy: Expects origin for iframe-tag to cross-http origin and keep-origin redirection from http context.]
expected: FAIL
[Referrer Policy: Expects origin for iframe-tag to cross-http origin and no-redirect redirection from http context.]
expected: FAIL
[Referrer Policy: Expects origin for iframe-tag to cross-http origin and swap-origin redirection from http context.]
expected: FAIL
[Referrer Policy: Expects origin for iframe-tag to cross-https origin and keep-origin redirection from http context.]
expected: FAIL
[Referrer Policy: Expects origin for iframe-tag to cross-https origin and no-redirect redirection from http context.]
expected: FAIL
[Referrer Policy: Expects origin for iframe-tag to cross-https origin and swap-origin redirection from http context.]
expected: FAIL
[Referrer Policy: Expects origin for iframe-tag to same-http origin and keep-origin redirection from http context.]
expected: FAIL
[Referrer Policy: Expects origin for iframe-tag to same-http origin and no-redirect redirection from http context.]
expected: FAIL
[Referrer Policy: Expects origin for iframe-tag to same-http origin and swap-origin redirection from http context.]
expected: FAIL
[Referrer Policy: Expects origin for iframe-tag to same-https origin and keep-origin redirection from http context.]
expected: FAIL
[Referrer Policy: Expects origin for iframe-tag to same-https origin and no-redirect redirection from http context.]
expected: FAIL
[Referrer Policy: Expects origin for iframe-tag to same-https origin and swap-origin redirection from http context.]
expected: FAIL

3
tests/wpt/meta/referrer-policy/generic/iframe-src-change.html.ini vendored
View file

@ -1,3 +0,0 @@
[iframe-src-change.html]
[Checks that referrerpolicy is respected when an iframe's src changes.]
expected: FAIL