Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-30 00:29:14 +01:00
Code Issues Projects Releases Packages Wiki Activity

compositor: Hide IpcSender as implementation detail (#38963)

Browse source 
The `CrossProcessCompositorApi` already provides methods for most
messages.
Remove the `sender()` method, and hide the IpcSender as an
implementation detail. This is a preparation for abstracting over the
internal IpcSender.

Testing: No functional changes

---------

Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
This commit is contained in:
Jonathan Schwender 2025-08-27 11:42:01 +02:00 • committed by GitHub
parent 5909eb7684
commit 33e934421e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 29 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

8
components/script/dom/htmlmetaelement.rs
View file

@ -4,7 +4,6 @@
use std::str::FromStr;
use compositing_traits::CompositorMsg;
use compositing_traits::viewport_description::ViewportDescription;
use dom_struct::dom_struct;
use html5ever::{LocalName, Prefix, local_name, ns};
@ -136,12 +135,7 @@ impl HTMLMetaElement {
if let Ok(viewport) = ViewportDescription::from_str(&content.value()) {
self.owner_window()
.compositor_api()
.sender()
.send(CompositorMsg::Viewport(
self.owner_window().webview_id(),
viewport,
))
.unwrap();
.viewport(self.owner_window().webview_id(), viewport);
}
}

10
components/script/script_thread.rs
View file

@ -36,7 +36,7 @@ use base::cross_process_instant::CrossProcessInstant;
use base::id::{BrowsingContextId, HistoryStateId, PipelineId, PipelineNamespace, WebViewId};
use canvas_traits::webgl::WebGLPipeline;
use chrono::{DateTime, Local};
use compositing_traits::{CompositorMsg, CrossProcessCompositorApi, PipelineExitSource};
use compositing_traits::{CrossProcessCompositorApi, PipelineExitSource};
use constellation_traits::{
JsEvalResult, LoadData, LoadOrigin, NavigationHistoryBehavior, ScriptToConstellationChan,
ScriptToConstellationMessage, StructuredSerializedData, WindowSizeType,
@ -2956,13 +2956,7 @@ impl ScriptThread {
.ok();
self.compositor_api
.sender()
.send(CompositorMsg::PipelineExited(
webview_id,
id,
PipelineExitSource::Script,
))
.ok();
.pipeline_exited(webview_id, id, PipelineExitSource::Script);
debug!("{id}: Finished pipeline exit");
}