From 33f5066a230a1cd6e3edfbc9544fad93e261153a Mon Sep 17 00:00:00 2001 From: Josh Matthews Date: Wed, 20 Mar 2019 10:09:00 -0400 Subject: [PATCH] Make unclean manifest error show actual erroring manifest. --- tests/wpt/manifestupdate.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/wpt/manifestupdate.py b/tests/wpt/manifestupdate.py index 85d73757a46..638dcaecfb9 100644 --- a/tests/wpt/manifestupdate.py +++ b/tests/wpt/manifestupdate.py @@ -85,9 +85,8 @@ def _check_clean(logger, test_paths): for manifest_path, (old_manifest, new_manifest) in manifests_by_path.iteritems(): if not diff_manifests(logger, manifest_path, old_manifest, new_manifest): + logger.error("Manifest %s is outdated, use |./mach update-manifest| to fix." % manifest_path) rv = 1 - if rv: - logger.error("Manifest %s is outdated, use |./mach update-manifest| to fix." % manifest_path) return rv