mirror of
https://github.com/servo/servo.git
synced 2025-08-06 14:10:11 +01:00
Auto merge of #21222 - nupurbaghel:update_source_set, r=jdm
Null image source check for src, srcset and picture parent <!-- Please describe your changes on the following line: --> This PR includes a test which checks for empty src only. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #21221 <!-- Either: --> - [x] These changes require tests and added <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21222) <!-- Reviewable:end -->
This commit is contained in:
commit
3424a5c51f
2 changed files with 40 additions and 0 deletions
|
@ -357185,6 +357185,12 @@
|
|||
{}
|
||||
]
|
||||
],
|
||||
"html/semantics/embedded-content/the-img-element/null-image-source.html": [
|
||||
[
|
||||
"/html/semantics/embedded-content/the-img-element/null-image-source.html",
|
||||
{}
|
||||
]
|
||||
],
|
||||
"html/semantics/embedded-content/the-img-element/relevant-mutations.html": [
|
||||
[
|
||||
"/html/semantics/embedded-content/the-img-element/relevant-mutations.html",
|
||||
|
@ -597948,6 +597954,10 @@
|
|||
"4d929fd8b160205f1f0fd7ab019cbb31411c69ad",
|
||||
"testharness"
|
||||
],
|
||||
"html/semantics/embedded-content/the-img-element/null-image-source.html": [
|
||||
"89992765036636c2b9eafbe9b579214fcc55346f",
|
||||
"testharness"
|
||||
],
|
||||
"html/semantics/embedded-content/the-img-element/relevant-mutations.html": [
|
||||
"c8e09e8d0b8a7abbec87632b9f55240505d1ccc7",
|
||||
"testharness"
|
||||
|
|
|
@ -0,0 +1,30 @@
|
|||
<!doctype html>
|
||||
<meta charset="utf-8">
|
||||
<title>Null image source check for src, srcset and picture parent</title>
|
||||
<script src="/resources/testharness.js"></script>
|
||||
<script src="/resources/testharnessreport.js"></script>
|
||||
<div id=log></div>
|
||||
<img id="src_id" src="">
|
||||
<img id="srcset_id" srcset="">
|
||||
<picture><img id="parent_picture_id"></picture>
|
||||
<script>
|
||||
async_test(function(t) {
|
||||
img = document.getElementById('src_id');
|
||||
img.onerror = t.step_func(function(e) {
|
||||
assert_equals(e.type, "error", "null image source check failed");
|
||||
t.done();
|
||||
});
|
||||
}, "img with empty src");
|
||||
|
||||
async_test(function(t) {
|
||||
img = document.getElementById('srcset_id');
|
||||
img.onerror = t.unreached_func("empty srcset fires an error");
|
||||
t.step_timeout(function() { t.done(); }, 2000);
|
||||
}, "img with empty srcset");
|
||||
|
||||
async_test(function(t) {
|
||||
img = document.getElementById('parent_picture_id');
|
||||
img.onerror = t.unreached_func("null img with picture parent fires an error");
|
||||
t.step_timeout(function() { t.done(); }, 2000);
|
||||
}, "img with picture parent");
|
||||
</script>
|
Loading…
Add table
Add a link
Reference in a new issue