From 799490d92085106fc41a59a8fe062f1b98b8ab89 Mon Sep 17 00:00:00 2001 From: Simon Sapin Date: Tue, 24 May 2016 18:17:11 +0200 Subject: [PATCH] =?UTF-8?q?Don=E2=80=99t=20include=20microsecons=20when=20?= =?UTF-8?q?reporting=20build=20times.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit "0:03:40.817715" is harder to read and no more informative than "0:03:40" --- python/servo/build_commands.py | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/python/servo/build_commands.py b/python/servo/build_commands.py index 369918595ce..33647335791 100644 --- a/python/servo/build_commands.py +++ b/python/servo/build_commands.py @@ -26,6 +26,10 @@ from mach.decorators import ( from servo.command_base import CommandBase, cd, call +def format_duration(seconds): + return str(datetime.timedelta(seconds=int(seconds))) + + def notify_linux(title, text): try: import dbus @@ -86,7 +90,7 @@ def notify_build_done(elapsed): """Generate desktop notification when build is complete and the elapsed build time was longer than 30 seconds.""" if elapsed > 30: - notify("Servo build", "Completed in %s" % str(datetime.timedelta(seconds=elapsed))) + notify("Servo build", "Completed in %s" % format_duration(elapsed)) def notify(title, text): @@ -238,7 +242,7 @@ class MachCommands(CommandBase): # Generate Desktop Notification if elapsed-time > some threshold value notify_build_done(elapsed) - print("Build completed in %s" % str(datetime.timedelta(seconds=elapsed))) + print("Build completed in %s" % format_duration(elapsed)) return status @Command('build-cef', @@ -274,7 +278,7 @@ class MachCommands(CommandBase): # Generate Desktop Notification if elapsed-time > some threshold value notify_build_done(elapsed) - print("CEF build completed in %s" % str(datetime.timedelta(seconds=elapsed))) + print("CEF build completed in %s" % format_duration(elapsed)) return ret @@ -311,7 +315,7 @@ class MachCommands(CommandBase): # Generate Desktop Notification if elapsed-time > some threshold value notify_build_done(elapsed) - print("GeckoLib build completed in %s" % str(datetime.timedelta(seconds=elapsed))) + print("GeckoLib build completed in %s" % format_duration(elapsed)) return ret @@ -349,7 +353,7 @@ class MachCommands(CommandBase): # Generate Desktop Notification if elapsed-time > some threshold value notify_build_done(elapsed) - print("Gonk build completed in %s" % str(datetime.timedelta(seconds=elapsed))) + print("Gonk build completed in %s" % format_duration(elapsed)) return ret