From 346d705c66a56d9074021ed97ac596f547deb34c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fernando=20Jim=C3=A9nez=20Moreno?= Date: Tue, 18 Sep 2018 17:45:03 +0200 Subject: [PATCH] Do not skip buffer update during copyToChannel --- components/script/dom/audiobuffer.rs | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/components/script/dom/audiobuffer.rs b/components/script/dom/audiobuffer.rs index 5143bb82304..8e8287ccb3c 100644 --- a/components/script/dom/audiobuffer.rs +++ b/components/script/dom/audiobuffer.rs @@ -238,18 +238,14 @@ impl AudioBufferMethods for AudioBuffer { let mut dest = Vec::with_capacity(destination.len()); // We either copy form js_channels or shared_channels. - let js_channel = self.js_channels.borrow()[channel_number].get(); if !js_channel.is_null() { typedarray!(in(cx) let array: Float32Array = js_channel); if let Ok(array) = array { let data = unsafe { array.as_slice() }; dest.extend_from_slice(&data[offset..offset + bytes_to_copy]); - return Ok(()); } - } - - if let Some(shared_channel) = self.shared_channels.borrow().buffers.get(channel_number) { + } else if let Some(shared_channel) = self.shared_channels.borrow().buffers.get(channel_number) { dest.extend_from_slice(&shared_channel.as_slice()[offset..offset + bytes_to_copy]); }