From 350a6080d7cb267c62dc5ee06dd657393eef1d52 Mon Sep 17 00:00:00 2001 From: Ms2ger Date: Tue, 15 Jul 2014 20:05:51 +0200 Subject: [PATCH] Support FormData outside Window scopes. --- src/components/script/dom/formdata.rs | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/src/components/script/dom/formdata.rs b/src/components/script/dom/formdata.rs index 8f5c2cfcd19..221865a4960 100644 --- a/src/components/script/dom/formdata.rs +++ b/src/components/script/dom/formdata.rs @@ -6,14 +6,13 @@ use dom::bindings::codegen::Bindings::FormDataBinding; use dom::bindings::codegen::InheritTypes::FileCast; use dom::bindings::codegen::UnionTypes::FileOrString::{FileOrString, eFile, eString}; use dom::bindings::error::{Fallible}; -use dom::bindings::global::{GlobalRef, Window}; +use dom::bindings::global::{GlobalRef, GlobalField}; use dom::bindings::js::{JS, JSRef, Temporary}; use dom::bindings::trace::Traceable; use dom::bindings::utils::{Reflectable, Reflector, reflect_dom_object}; use dom::blob::Blob; use dom::file::File; use dom::htmlformelement::HTMLFormElement; -use dom::window::Window; use servo_util::str::DOMString; use std::cell::RefCell; use std::collections::hashmap::HashMap; @@ -28,27 +27,27 @@ pub enum FormDatum { pub struct FormData { data: Traceable>>>, reflector_: Reflector, - window: JS, + global: GlobalField, form: Option> } impl FormData { - pub fn new_inherited(form: Option>, window: &JSRef) -> FormData { + pub fn new_inherited(form: Option>, global: &GlobalRef) -> FormData { FormData { data: Traceable::new(RefCell::new(HashMap::new())), reflector_: Reflector::new(), - window: JS::from_rooted(window), + global: GlobalField::from_rooted(global), form: form.map(|f| JS::from_rooted(&f)), } } - pub fn new(form: Option>, window: &JSRef) -> Temporary { - reflect_dom_object(box FormData::new_inherited(form, window), - &Window(*window), FormDataBinding::Wrap) + pub fn new(form: Option>, global: &GlobalRef) -> Temporary { + reflect_dom_object(box FormData::new_inherited(form, global), + global, FormDataBinding::Wrap) } pub fn Constructor(global: &GlobalRef, form: Option>) -> Fallible> { - Ok(FormData::new(form, global.as_window())) + Ok(FormData::new(form, global)) } } @@ -117,9 +116,9 @@ trait PrivateFormDataHelpers{ impl PrivateFormDataHelpers for FormData { fn get_file_from_blob(&self, value: &JSRef, filename: Option) -> Temporary { - let window = self.window.root(); + let global = self.global.root(); let f: Option<&JSRef> = FileCast::to_ref(value); let name = filename.unwrap_or(f.map(|inner| inner.name.clone()).unwrap_or("blob".to_string())); - File::new(&Window(*window), value, name) + File::new(&global.root_ref(), value, name) } }