diff --git a/components/constellation/constellation.rs b/components/constellation/constellation.rs index f954fda7668..2d9fbac74d9 100644 --- a/components/constellation/constellation.rs +++ b/components/constellation/constellation.rs @@ -1323,10 +1323,13 @@ impl Constellation } } - fn handle_alert(&mut self, pipeline_id: PipelineId, message: String, sender: IpcSender) { + fn handle_alert(&mut self, + pipeline_id: PipelineId, + message: String, + sender: IpcSender) { let display_alert_dialog = if PREFS.is_mozbrowser_enabled() { let parent_pipeline_info = self.pipelines.get(&pipeline_id).and_then(|source| source.parent_info); - if let Some(_) = parent_pipeline_info { + if parent_pipeline_info.is_some() { let root_pipeline_id = self.root_frame_id .and_then(|root_frame_id| self.frames.get(&root_frame_id)) .map(|root_frame| root_frame.current.0); diff --git a/components/constellation/pipeline.rs b/components/constellation/pipeline.rs index dd2a665f6ac..3c076e904e0 100644 --- a/components/constellation/pipeline.rs +++ b/components/constellation/pipeline.rs @@ -501,6 +501,10 @@ impl UnprivilegedPipelineContent { command.env("RUST_BACKTRACE", value); } + if let Ok(value) = env::var("RUST_LOG") { + command.env("RUST_LOG", value); + } + let profile = content_process_sandbox_profile(); ChildProcess::Sandboxed(Sandbox::new(profile).start(&mut command) .expect("Failed to start sandboxed child process!")) @@ -515,6 +519,10 @@ impl UnprivilegedPipelineContent { child_process.env("RUST_BACKTRACE", value); } + if let Ok(value) = env::var("RUST_LOG") { + child_process.env("RUST_LOG", value); + } + ChildProcess::Unsandboxed(child_process.spawn() .expect("Failed to start unsandboxed child process!")) }; diff --git a/components/gfx/paint_thread.rs b/components/gfx/paint_thread.rs index b4ad2abd299..6fad77dbcf3 100644 --- a/components/gfx/paint_thread.rs +++ b/components/gfx/paint_thread.rs @@ -379,8 +379,7 @@ impl PaintThread where C: PaintListener + Send + 'static { font_cache_thread: FontCacheThread, time_profiler_chan: time::ProfilerChan, mem_profiler_chan: mem::ProfilerChan) { - thread::spawn_named(format!("PaintThread {:?}", id), - move || { + thread::spawn_named(format!("PaintThread {:?}", id), move || { thread_state::initialize(thread_state::PAINT); PipelineId::install(id); @@ -425,9 +424,9 @@ impl PaintThread where C: PaintListener + Send + 'static { let chrome_to_paint = &self.chrome_to_paint_port; select! { msg = layout_to_paint.recv() => - Msg::FromLayout(msg.unwrap()), + Msg::FromLayout(msg.expect("expected message from layout")), msg = chrome_to_paint.recv() => - Msg::FromChrome(msg.unwrap()) + Msg::FromChrome(msg.expect("expected message from chrome")) } }; diff --git a/components/script/dom/document.rs b/components/script/dom/document.rs index 14e80de6346..73ca4f16f3c 100644 --- a/components/script/dom/document.rs +++ b/components/script/dom/document.rs @@ -2915,6 +2915,7 @@ impl DocumentProgressHandler { // http://w3c.github.io/navigation-timing/#widl-PerformanceNavigationTiming-loadEventStart update_with_current_time_ms(&document.load_event_start); + debug!("About to dispatch load for {:?}", document.url()); let _ = wintarget.dispatch_event_with_target(document.upcast(), &event); // http://w3c.github.io/navigation-timing/#widl-PerformanceNavigationTiming-loadEventEnd