Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-22 06:43:40 +01:00
Code Issues Projects Releases Packages Wiki Activity

HTMLMediaElement - fire durationchange and resize iff something changes

Browse source
This commit is contained in:
Fernando Jiménez Moreno 2018-10-30 12:02:42 +01:00
parent b5b8550fb2
commit 35508c152a
2 changed files with 22 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

20
components/script/dom/htmlmediaelement.rs
View file

@ -1122,21 +1122,29 @@ impl HTMLMediaElement {
self.playback_position.set(0.); self.playback_position.set(0.);
// Step 4. // Step 4.
let previous_duration = self.duration.get();
if let Some(duration) = metadata.duration { if let Some(duration) = metadata.duration {
self.duration.set(duration.as_secs() as f64); self.duration.set(duration.as_secs() as f64);
} else { } else {
self.duration.set(f64::INFINITY); self.duration.set(f64::INFINITY);
} }
let window = window_from_node(self); if previous_duration != self.duration.get() {
let task_source = window.dom_manipulation_task_source(); let window = window_from_node(self);
task_source.queue_simple_event(self.upcast(), atom!("durationchange"), &window); let task_source = window.dom_manipulation_task_source();
task_source.queue_simple_event(self.upcast(), atom!("durationchange"), &window);
}
// Step 5. // Step 5.
if self.is::<HTMLVideoElement>() { if self.is::<HTMLVideoElement>() {
let video_elem = self.downcast::<HTMLVideoElement>().unwrap(); let video_elem = self.downcast::<HTMLVideoElement>().unwrap();
video_elem.set_video_width(metadata.width); if video_elem.get_video_width() != metadata.width ||
video_elem.set_video_height(metadata.height); video_elem.get_video_height() != metadata.height {
task_source.queue_simple_event(self.upcast(), atom!("resize"), &window); video_elem.set_video_width(metadata.width);
video_elem.set_video_height(metadata.height);
let window = window_from_node(self);
let task_source = window.dom_manipulation_task_source();
task_source.queue_simple_event(self.upcast(), atom!("resize"), &window);
}
} }
// Step 6. // Step 6.

8
components/script/dom/htmlvideoelement.rs
View file

@ -49,10 +49,18 @@ impl HTMLVideoElement {
) )
} }
pub fn get_video_width(&self) -> u32 {
self.video_width.get()
}
pub fn set_video_width(&self, width: u32) { pub fn set_video_width(&self, width: u32) {
self.video_width.set(width); self.video_width.set(width);
} }
pub fn get_video_height(&self) -> u32 {
self.video_height.get()
}
pub fn set_video_height(&self, height: u32) { pub fn set_video_height(&self, height: u32) {
self.video_height.set(height); self.video_height.set(height);
} }