Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 13:40:08 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fixed issue #11651 (Do not fire a blur event when calling .focus() on a focused element)

Browse source
This commit is contained in:
Davide Giovannini 2016-06-07 20:36:29 +02:00
parent f56848a0e8
commit 35aa24eb4c
2 changed files with 22 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

36
components/script/dom/document.rs
View file

@ -598,25 +598,27 @@ impl Document {
/// Reassign the focus context to the element that last requested focus during this /// Reassign the focus context to the element that last requested focus during this
/// transaction, or none if no elements requested it. /// transaction, or none if no elements requested it.
pub fn commit_focus_transaction(&self, focus_type: FocusType) { pub fn commit_focus_transaction(&self, focus_type: FocusType) {
if let Some(ref elem) = self.focused.get() { if self.focused != self.possibly_focused.get().r() {
let node = elem.upcast::<Node>(); if let Some(ref elem) = self.focused.get() {
elem.set_focus_state(false); let node = elem.upcast::<Node>();
// FIXME: pass appropriate relatedTarget elem.set_focus_state(false);
self.fire_focus_event(FocusEventType::Blur, node, None); // FIXME: pass appropriate relatedTarget
} self.fire_focus_event(FocusEventType::Blur, node, None);
}
self.focused.set(self.possibly_focused.get().r()); self.focused.set(self.possibly_focused.get().r());
if let Some(ref elem) = self.focused.get() { if let Some(ref elem) = self.focused.get() {
elem.set_focus_state(true); elem.set_focus_state(true);
let node = elem.upcast::<Node>(); let node = elem.upcast::<Node>();
// FIXME: pass appropriate relatedTarget // FIXME: pass appropriate relatedTarget
self.fire_focus_event(FocusEventType::Focus, node, None); self.fire_focus_event(FocusEventType::Focus, node, None);
// Update the focus state for all elements in the focus chain. // Update the focus state for all elements in the focus chain.
// https://html.spec.whatwg.org/multipage/#focus-chain // https://html.spec.whatwg.org/multipage/#focus-chain
if focus_type == FocusType::Element { if focus_type == FocusType::Element {
let event = ConstellationMsg::Focus(self.window.pipeline()); let event = ConstellationMsg::Focus(self.window.pipeline());
self.window.constellation_chan().send(event).unwrap(); self.window.constellation_chan().send(event).unwrap();
}
} }
} }
} }

3
components/script/dom/htmlelement.rs
View file

@ -251,6 +251,9 @@ impl HTMLElementMethods for HTMLElement {
fn Focus(&self) { fn Focus(&self) {
// TODO: Mark the element as locked for focus and run the focusing steps. // TODO: Mark the element as locked for focus and run the focusing steps.
// https://html.spec.whatwg.org/multipage/#focusing-steps // https://html.spec.whatwg.org/multipage/#focusing-steps
if self.upcast::<Element>().focus_state() {
return;
}
let document = document_from_node(self); let document = document_from_node(self);
document.begin_focus_transaction(); document.begin_focus_transaction();
document.request_focus(self.upcast()); document.request_focus(self.upcast());