Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 05:30:08 +01:00
Code Issues Projects Releases Packages Wiki Activity

Move storing promise in decode task

Browse source 
Signed-off-by: Bentaimia Haddadi <haddadi.taym@gmail.com>
This commit is contained in:
Bentaimia Haddadi 2024-06-11 16:45:32 +02:00
parent fb5b00a938
commit 35aacbe140
1 changed files with 13 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

20
components/script/dom/htmlimageelement.rs
View file

@ -1173,7 +1173,11 @@ impl HTMLImageElement {
} }
// Step 2 for <https://html.spec.whatwg.org/multipage/#dom-img-decode> // Step 2 for <https://html.spec.whatwg.org/multipage/#dom-img-decode>
fn react_to_decode_image_sync_steps(&self) { fn react_to_decode_image_sync_steps(&self, promise: Rc<Promise>) {
self.image_decode_promises
.borrow_mut()
.push(promise.clone());
let document = document_from_node(self); let document = document_from_node(self);
// Step 2.1 of <https://html.spec.whatwg.org/multipage/#dom-img-decode> // Step 2.1 of <https://html.spec.whatwg.org/multipage/#dom-img-decode>
if !document.is_fully_active() || if !document.is_fully_active() ||
@ -1399,6 +1403,8 @@ pub enum ImageElementMicrotask {
}, },
DecodeTask { DecodeTask {
elem: DomRoot<HTMLImageElement>, elem: DomRoot<HTMLImageElement>,
#[ignore_malloc_size_of = "promises are hard"]
promise: Rc<Promise>,
}, },
} }
@ -1421,8 +1427,11 @@ impl MicrotaskRunnable for ImageElementMicrotask {
} => { } => {
elem.react_to_environment_changes_sync_steps(*generation); elem.react_to_environment_changes_sync_steps(*generation);
}, },
ImageElementMicrotask::DecodeTask { ref elem } => { ImageElementMicrotask::DecodeTask {
elem.react_to_decode_image_sync_steps(); ref elem,
ref promise,
} => {
elem.react_to_decode_image_sync_steps(promise.clone());
}, },
} }
} }
@ -1669,13 +1678,10 @@ impl HTMLImageElementMethods for HTMLImageElement {
// Step 1 // Step 1
let promise = Promise::new(&self.global()); let promise = Promise::new(&self.global());
self.image_decode_promises
.borrow_mut()
.push(promise.clone());
// Step 2 // Step 2
let task = ImageElementMicrotask::DecodeTask { let task = ImageElementMicrotask::DecodeTask {
elem: DomRoot::from_ref(self), elem: DomRoot::from_ref(self),
promise: promise.clone(),
}; };
ScriptThread::await_stable_state(Microtask::ImageElement(task)); ScriptThread::await_stable_state(Microtask::ImageElement(task));