Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-06-28 19:13:41 +01:00
Code Issues Projects Releases Packages Wiki Activity

Report error when vcvarsall fails

Browse source
This commit is contained in:
Manish Goregaokar 2020-04-15 22:55:05 -07:00
parent 16230ee279
commit 371ba67d55
1 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
python/servo/build_commands.py
View file

@ -315,11 +315,15 @@ class MachCommands(CommandBase):
process = subprocess.Popen('("%s" %s > nul) && "python" -c "import os; print(repr(os.environ))"' % process = subprocess.Popen('("%s" %s > nul) && "python" -c "import os; print(repr(os.environ))"' %
(os.path.join(vs_dirs['vcdir'], "Auxiliary", "Build", "vcvarsall.bat"), "x64"), (os.path.join(vs_dirs['vcdir'], "Auxiliary", "Build", "vcvarsall.bat"), "x64"),
stdout=subprocess.PIPE, shell=True) stdout=subprocess.PIPE, shell=True)
stdout, _ = process.communicate() stdout, stderr = process.communicate()
exitcode = process.wait() exitcode = process.wait()
encoding = locale.getpreferredencoding() # See https://stackoverflow.com/a/9228117 encoding = locale.getpreferredencoding() # See https://stackoverflow.com/a/9228117
if exitcode == 0: if exitcode == 0:
os.environ.update(eval(stdout.decode(encoding))) os.environ.update(eval(stdout.decode(encoding)))
else:
print("Failed to run vcvarsall. stderr:")
print(stderr.decode(encoding))
exit(1)
# Ensure that GStreamer libraries are accessible when linking. # Ensure that GStreamer libraries are accessible when linking.
if 'windows' in target_triple: if 'windows' in target_triple: