From 4a23f6f2d057ef4186eac12d8b37bb5821aa5421 Mon Sep 17 00:00:00 2001 From: Martin Robinson Date: Tue, 3 Nov 2015 15:31:15 -0800 Subject: [PATCH] Print process output for TIMEOUT status in WPT UI Tests can time out due to script or runtime errors, which are typically reported via the Servo process output. Including process output for tests timing out makes it easier to understand these problems. --- tests/wpt/grouping_formatter.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tests/wpt/grouping_formatter.py b/tests/wpt/grouping_formatter.py index 614c3c0ae37..be2e0514a5b 100644 --- a/tests/wpt/grouping_formatter.py +++ b/tests/wpt/grouping_formatter.py @@ -167,9 +167,10 @@ class GroupingFormatter(base.BaseFormatter): self.expected[test_status] += 1 return self.generate_output(text=None, new_display=new_display) - # If the test crashed, we also include any process output, because there is a good - # chance that the test produced a stack trace. - if test_status == "CRASH": + # If the test crashed or timed out, we also include any process output, + # because there is a good chance that the test produced a stack trace + # or other error messages. + if test_status in ("CRASH", "TIMEOUT"): stack = self.test_output[test_name] + data.get('stack', "") else: stack = data.get('stack', None)