Auto merge of #25719 - pshaughn:controlbeforeform, r=jdm

Make HTMLFormControlsCollection rooted at the form's root, not rooted at the form itself

<!-- Please describe your changes on the following line: -->
We'd been misreading the first line of https://html.spec.whatwg.org/#dom-form-elements. The collection needs to be rooted higher than the form itself, so it can contain form controls elsewhere in the document with a form= content attribute. It is, as far as I can tell, unspecified whether "rooted at the form's root" is meant to live-update to a new root if the form is moved to another tree, and I'm assuming it doesn't have to.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25711

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

components/script/dom/htmlformcontrolscollection.rs

@@ -5,10 +5,11 @@
 use crate::dom::bindings::codegen::Bindings::HTMLCollectionBinding::HTMLCollectionMethods;
 use crate::dom::bindings::codegen::Bindings::HTMLFormControlsCollectionBinding;
 use crate::dom::bindings::codegen::Bindings::HTMLFormControlsCollectionBinding::HTMLFormControlsCollectionMethods;
+use crate::dom::bindings::codegen::Bindings::NodeBinding::{GetRootNodeOptions, NodeMethods};
 use crate::dom::bindings::codegen::UnionTypes::RadioNodeListOrElement;
 use crate::dom::bindings::inheritance::Castable;
 use crate::dom::bindings::reflector::{reflect_dom_object, DomObject};
-use crate::dom::bindings::root::DomRoot;
+use crate::dom::bindings::root::{Dom, DomRoot};
 use crate::dom::bindings::str::DOMString;
 use crate::dom::element::Element;
 use crate::dom::htmlcollection::{CollectionFilter, HTMLCollection};
@@ -21,25 +22,30 @@ use dom_struct::dom_struct;
 #[dom_struct]
 pub struct HTMLFormControlsCollection {
     collection: HTMLCollection,
+    form: Dom<HTMLFormElement>,
 }
 
 impl HTMLFormControlsCollection {
     fn new_inherited(
-        root: &HTMLFormElement,
+        form: &HTMLFormElement,
         filter: Box<dyn CollectionFilter + 'static>,
     ) -> HTMLFormControlsCollection {
+        let root_of_form = form
+            .upcast::<Node>()
+            .GetRootNode(&GetRootNodeOptions::empty());
         HTMLFormControlsCollection {
-            collection: HTMLCollection::new_inherited(root.upcast::<Node>(), filter),
+            collection: HTMLCollection::new_inherited(&*root_of_form, filter),
+            form: Dom::from_ref(form),
         }
     }
 
     pub fn new(
         window: &Window,
-        root: &HTMLFormElement,
+        form: &HTMLFormElement,
         filter: Box<dyn CollectionFilter + 'static>,
     ) -> DomRoot<HTMLFormControlsCollection> {
         reflect_dom_object(
-            Box::new(HTMLFormControlsCollection::new_inherited(root, filter)),
+            Box::new(HTMLFormControlsCollection::new_inherited(form, filter)),
             window,
             HTMLFormControlsCollectionBinding::Wrap,
         )
@@ -80,14 +86,11 @@ impl HTMLFormControlsCollectionMethods for HTMLFormControlsCollection {
                 // Step 4-5
                 let global = self.global();
                 let window = global.as_window();
-                // okay to unwrap: root's type was checked in the constructor
-                let collection_root = self.collection.root_node();
-                let form = collection_root.downcast::<HTMLFormElement>().unwrap();
                 // There is only one way to get an HTMLCollection,
                 // specifically HTMLFormElement::Elements(),
                 // and the collection filter excludes image inputs.
                 Some(RadioNodeListOrElement::RadioNodeList(
-                    RadioNodeList::new_controls_except_image_inputs(window, form, name),
+                    RadioNodeList::new_controls_except_image_inputs(window, &*self.form, name),
                 ))
             }
         // Step 3

tests/wpt/metadata/html/semantics/forms/the-form-element/form-elements-filter.html.ini

@@ -1,8 +1,5 @@
 [form-elements-filter.html]
   type: testharness
-  [form.elements must contain all listed elements with the form owner]
-    expected: FAIL
-
   [form.elements only includes elements from the same shadow tree]
     expected: FAIL