From 375dd5788783aa834edf4b264ae592e7ac3866a7 Mon Sep 17 00:00:00 2001 From: Patrick Walton Date: Thu, 4 Oct 2012 17:46:41 -0700 Subject: [PATCH] Add libwapcaplet submodule (a dependency of libcss) --- .gitmodules | 3 +++ configure | 2 +- src/libwapcaplet | 1 + src/servo/gfx/display_list.rs | 2 ++ src/servo/layout/display_list_builder.rs | 4 ++-- src/servo/layout/inline.rs | 1 + src/servo/text/font.rs | 4 ++-- 7 files changed, 12 insertions(+), 5 deletions(-) create mode 160000 src/libwapcaplet diff --git a/.gitmodules b/.gitmodules index 2b83742c8a2..f2f0ea48353 100644 --- a/.gitmodules +++ b/.gitmodules @@ -52,4 +52,7 @@ [submodule "src/sharegl"] path = src/sharegl url = git://github.com/pcwalton/sharegl.git +[submodule "src/libwapcaplet"] + path = src/libwapcaplet + url = git://github.com/pcwalton/libwapcaplet.git diff --git a/configure b/configure index dfb3f05541a..3309f87db98 100755 --- a/configure +++ b/configure @@ -344,7 +344,7 @@ step_msg "running submodule autoconf scripts" (cd ${CFG_SRC_DIR}src/mozjs/js/src && "${CFG_AUTOCONF213}") || exit $? -CFG_SUBMODULES="rust-harfbuzz rust-opengles rust-azure rust-stb-image rust-geom rust-glut rust-layers rust-http-client libparserutils libhubbub servo-sandbox rust-hubbub sharegl rust-mozjs mozjs" +CFG_SUBMODULES="libwapcaplet rust-harfbuzz rust-opengles rust-azure rust-stb-image rust-geom rust-glut rust-layers rust-http-client libparserutils libhubbub servo-sandbox rust-hubbub sharegl rust-mozjs mozjs" if [ $CFG_OSTYPE == "darwin" ] then diff --git a/src/libwapcaplet b/src/libwapcaplet new file mode 160000 index 00000000000..a7985f7732d --- /dev/null +++ b/src/libwapcaplet @@ -0,0 +1 @@ +Subproject commit a7985f7732da1fa3e87087863c041c5b49ef6a8d diff --git a/src/servo/gfx/display_list.rs b/src/servo/gfx/display_list.rs index 7a3d14f8743..1702eb29d7f 100644 --- a/src/servo/gfx/display_list.rs +++ b/src/servo/gfx/display_list.rs @@ -89,9 +89,11 @@ trait DisplayListMethods { impl DisplayList : DisplayListMethods { fn draw(ctx: &RenderContext) { + debug!("beginning display list"); for self.each |item| { debug!("drawing %?", *item); item.draw(*item, ctx); } + debug!("ending display list"); } } diff --git a/src/servo/layout/display_list_builder.rs b/src/servo/layout/display_list_builder.rs index 53c355d2637..8d7943b4759 100644 --- a/src/servo/layout/display_list_builder.rs +++ b/src/servo/layout/display_list_builder.rs @@ -39,14 +39,14 @@ trait FlowDisplayListBuilderMethods { } impl FlowContext: FlowDisplayListBuilderMethods { - fn build_display_list(builder: &DisplayListBuilder, dirty: &Rect, list: &dl::DisplayList) { let zero = au::zero_point(); self.build_display_list_recurse(builder, dirty, &zero, list); } fn build_display_list_for_child(builder: &DisplayListBuilder, child: @FlowContext, - dirty: &Rect, offset: &Point2D, list: &dl::DisplayList) { + dirty: &Rect, offset: &Point2D, + list: &dl::DisplayList) { // adjust the dirty rect to child flow context coordinates let adj_dirty = dirty.translate(&child.d().position.origin); diff --git a/src/servo/layout/inline.rs b/src/servo/layout/inline.rs index 678ee2f3903..cf37322e12b 100644 --- a/src/servo/layout/inline.rs +++ b/src/servo/layout/inline.rs @@ -161,6 +161,7 @@ impl FlowContext : InlineLayout { // TODO: once we form line boxes and have their cached bounds, we can be // smarter and not recurse on a line if nothing in it can intersect dirty + debug!("building display list for %u", self.inline().boxes.len()); for self.inline().boxes.each |box| { box.build_display_list(builder, dirty, offset, list) } diff --git a/src/servo/text/font.rs b/src/servo/text/font.rs index 0e3dd7aa868..d9806a57126 100644 --- a/src/servo/text/font.rs +++ b/src/servo/text/font.rs @@ -87,7 +87,7 @@ fn should_get_glyph_advance() { let lib = FontCache(); let font = lib.get_test_font(); let x = font.glyph_h_advance(40u as GlyphIndex); - assert x == 15; + assert x == 15 || x == 16; } // Testing thread safety @@ -103,7 +103,7 @@ fn should_get_glyph_advance_stress() { let lib = FontCache(); let font = lib.get_test_font(); let x = font.glyph_h_advance(40u as GlyphIndex); - assert x == 15; + assert x == 15 || x == 16; chan.send(()); } }