Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-23 15:23:42 +01:00
Code Issues Projects Releases Packages Wiki Activity

Don't re-add stylesheets to recompute vw/vh lengths

Browse source 
This is a follow-up to #9876.  It avoids clearing and rebuilding SelectorMaps
when vh and vw units need to be recomputed. Instead it just dirties all nodes,
to force elements to be re-cascaded.

Filed #10104 for later follow-up work to dirty only affected nodes.
This commit is contained in:
Matt Brubeck 2016-03-21 09:52:12 -07:00
parent e95368df62
commit 37636e8377
2 changed files with 8 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
components/layout/layout_thread.rs
View file

@ -1040,6 +1040,8 @@ impl LayoutThread {
}; };
// Handle conditions where the entire flow tree is invalid. // Handle conditions where the entire flow tree is invalid.
let mut needs_dirtying = false;
let viewport_size_changed = self.viewport_size != old_viewport_size; let viewport_size_changed = self.viewport_size != old_viewport_size;
if viewport_size_changed { if viewport_size_changed {
if let Some(constraints) = constraints { if let Some(constraints) = constraints {
@ -1048,11 +1050,15 @@ impl LayoutThread {
constellation_chan.send(ConstellationMsg::ViewportConstrained( constellation_chan.send(ConstellationMsg::ViewportConstrained(
self.id, constraints)).unwrap(); self.id, constraints)).unwrap();
} }
// FIXME (#10104): Only dirty nodes affected by vh/vw/vmin/vmax styles.
if data.document_stylesheets.iter().any(|sheet| sheet.dirty_on_viewport_size_change) {
needs_dirtying = true;
}
} }
// If the entire flow tree is invalid, then it will be reflowed anyhow. // If the entire flow tree is invalid, then it will be reflowed anyhow.
let needs_dirtying = rw_data.stylist.update(&data.document_stylesheets, needs_dirtying |= rw_data.stylist.update(&data.document_stylesheets,
data.stylesheets_changed); data.stylesheets_changed);
let needs_reflow = viewport_size_changed && !needs_dirtying; let needs_reflow = viewport_size_changed && !needs_dirtying;
unsafe { unsafe {
if needs_dirtying { if needs_dirtying {

3
components/style/selector_matching.rs
View file

@ -226,10 +226,7 @@ impl<Impl: SelectorImplExt> Stylist<Impl> {
device = Device::new(MediaType::Screen, constraints.size); device = Device::new(MediaType::Screen, constraints.size);
} }
let size_changed = device.viewport_size != self.device.viewport_size;
self.is_device_dirty |= stylesheets.iter().any(|stylesheet| { self.is_device_dirty |= stylesheets.iter().any(|stylesheet| {
(size_changed && stylesheet.dirty_on_viewport_size_change) ||
stylesheet.rules().media().any(|media_rule| stylesheet.rules().media().any(|media_rule|
media_rule.evaluate(&self.device) != media_rule.evaluate(&device)) media_rule.evaluate(&self.device) != media_rule.evaluate(&device))
}); });