Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 06:00:15 +01:00
Code Issues Projects Releases Packages Wiki Activity

script: Get scroll offsets from layout (#37509)

Browse source 
No longer store scroll offsets for elements in the DOM. Instead
consistently get and set these in layout's `ScrollTree`. This more
consistently requires layout to run when querying scroll offsets, which
ensures that they are up-to-date and properly bounded by scrollable
overflow area.

Testing: This causes several WPT tests to start passing, and one to
start
failing. In the case of
`/shadow-dom/scroll-to-the-fragment-in-shadow-tree.html`, I believe the
issue
is that we don't properly handle scrolling and shadow DOM elements.
Before, the
faulty scrolling was hiding this issue.

Signed-off-by: Martin Robinson <mrobinson@igalia.com>
This commit is contained in:
Martin Robinson 2025-06-20 11:39:12 +02:00 • committed by GitHub
parent 518729a4f5
commit 3774ef00d4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
14 changed files with 116 additions and 117 deletions
Download patch file Download diff file Expand all files Collapse all files

4
components/script/dom/element.rs
View file

@ -3080,7 +3080,7 @@ impl ElementMethods<crate::DomTypeHolder> for Element {
}
// Step 9
let point = node.scroll_offset();
let point = win.scroll_offset_query(node, can_gc);
point.y.abs() as f64
}
@ -3179,7 +3179,7 @@ impl ElementMethods<crate::DomTypeHolder> for Element {
}
// Step 9
let point = node.scroll_offset();
let point = win.scroll_offset_query(node, can_gc);
point.x.abs() as f64
}