From 37cf4cf207426f9c3b13feb617a14a6c25164894 Mon Sep 17 00:00:00 2001
From: Azhar Ismagulova <31756707+azharcodeit@users.noreply.github.com>
Date: Wed, 3 Apr 2024 18:19:53 +0100
Subject: [PATCH] clippy: Fix several warnings in
 `components/script/dom/bindings` (#31945)

* clippy: fix several warnings in components/script/dom/bindings

* fix: allow non_canonical_clone_impl in components/script/dom/bindings

* chore: removed unnecessary curly braces

* fix: removed vtable_address_comparisons allow
---
 components/script/dom/bindings/buffer_source.rs | 2 +-
 components/script/dom/bindings/interface.rs     | 2 +-
 components/script/dom/bindings/proxyhandler.rs  | 4 ++--
 components/script/dom/bindings/root.rs          | 3 ++-
 4 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/components/script/dom/bindings/buffer_source.rs b/components/script/dom/bindings/buffer_source.rs
index 5dc6cc43dab..d9f269afaec 100644
--- a/components/script/dom/bindings/buffer_source.rs
+++ b/components/script/dom/bindings/buffer_source.rs
@@ -418,7 +418,7 @@ where
     /// without causing conflicts , unexpected behavior.
     /// <https://github.com/servo/mozjs/blob/main/mozjs-sys/mozjs/js/public/ArrayBuffer.h#L89>
     unsafe extern "C" fn free_func(_contents: *mut c_void, free_user_data: *mut c_void) {
-        let _ = Arc::from_raw(free_user_data as _);
+        let _ = Arc::from_raw(free_user_data as *const _);
     }
 
     unsafe {
diff --git a/components/script/dom/bindings/interface.rs b/components/script/dom/bindings/interface.rs
index acce0362cf5..57d409e8d01 100644
--- a/components/script/dom/bindings/interface.rs
+++ b/components/script/dom/bindings/interface.rs
@@ -165,7 +165,7 @@ pub unsafe fn create_global_object(
     let private_val = PrivateValue(private);
     JS_SetReservedSlot(rval.get(), DOM_OBJECT_SLOT, &private_val);
     let proto_array: Box<ProtoOrIfaceArray> =
-        Box::new([0 as *mut JSObject; PrototypeList::PROTO_OR_IFACE_LENGTH]);
+        Box::new([ptr::null_mut::<JSObject>(); PrototypeList::PROTO_OR_IFACE_LENGTH]);
     let val = PrivateValue(Box::into_raw(proto_array) as *const libc::c_void);
     JS_SetReservedSlot(rval.get(), DOM_PROTOTYPE_SLOT, &val);
 
diff --git a/components/script/dom/bindings/proxyhandler.rs b/components/script/dom/bindings/proxyhandler.rs
index d7466604b5c..83104cf6bad 100644
--- a/components/script/dom/bindings/proxyhandler.rs
+++ b/components/script/dom/bindings/proxyhandler.rs
@@ -563,13 +563,13 @@ pub unsafe fn cross_origin_set(
 
 unsafe fn get_getter_object(d: &PropertyDescriptor, out: RawMutableHandleObject) {
     if d.hasGetter_() {
-        out.set(std::mem::transmute(d.getter_));
+        out.set(d.getter_);
     }
 }
 
 unsafe fn get_setter_object(d: &PropertyDescriptor, out: RawMutableHandleObject) {
     if d.hasSetter_() {
-        out.set(std::mem::transmute(d.setter_));
+        out.set(d.setter_);
     }
 }
 
diff --git a/components/script/dom/bindings/root.rs b/components/script/dom/bindings/root.rs
index bf393bf5531..de325707ee5 100644
--- a/components/script/dom/bindings/root.rs
+++ b/components/script/dom/bindings/root.rs
@@ -520,9 +520,10 @@ impl<T> Clone for Dom<T> {
 
 impl<T> Clone for LayoutDom<'_, T> {
     #[inline]
+    #[allow(clippy::non_canonical_clone_impl)]
     fn clone(&self) -> Self {
         assert_in_layout();
-        LayoutDom { value: self.value }
+        *self
     }
 }