mirror of
https://github.com/servo/servo.git
synced 2025-08-06 06:00:15 +01:00
Auto merge of #8129 - craftytrickster:pos-fixed-list-item, r=glennw
Made block type pattern match less inclusive Given the comments above the match statement, it seems that fixed-pos check should match only block elements in this case. Doing this change seems to partially resolve the issue where list items with `position:fixed;` styling are not displaying their bullet points. This change only resolves the issue for list items with `list-style-position: inside`, outside positioning is still not functioning correctly. https://github.com/servo/servo/issues/8001#issuecomment-149781613 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8129) <!-- Reviewable:end -->
This commit is contained in:
commit
381317f658
4 changed files with 63 additions and 2 deletions
|
@ -1470,7 +1470,7 @@ impl<'a> PostorderNodeMutTraversal for FlowConstructor<'a> {
|
|||
// flow here - instead, let it match the inline case
|
||||
// below.
|
||||
(display::T::block, _, position::T::absolute) |
|
||||
(_, _, position::T::fixed) => {
|
||||
(display::T::block, _, position::T::fixed) => {
|
||||
let construction_result = self.build_flow_for_block(node, None);
|
||||
self.set_flow_construction_result(node, construction_result)
|
||||
}
|
||||
|
|
|
@ -2075,6 +2075,18 @@
|
|||
"url": "/_mozilla/css/link_style_order.html"
|
||||
}
|
||||
],
|
||||
"css/list_style_fixed_inside_a.html": [
|
||||
{
|
||||
"path": "css/list_style_fixed_inside_a.html",
|
||||
"references": [
|
||||
[
|
||||
"/_mozilla/css/list_style_fixed_inside_ref.html",
|
||||
"=="
|
||||
]
|
||||
],
|
||||
"url": "/_mozilla/css/list_style_fixed_inside_a.html"
|
||||
}
|
||||
],
|
||||
"css/list_style_image_sizing_a.html": [
|
||||
{
|
||||
"path": "css/list_style_image_sizing_a.html",
|
||||
|
@ -6672,6 +6684,18 @@
|
|||
"url": "/_mozilla/css/link_style_order.html"
|
||||
}
|
||||
],
|
||||
"css/list_style_fixed_inside_a.html": [
|
||||
{
|
||||
"path": "css/list_style_fixed_inside_a.html",
|
||||
"references": [
|
||||
[
|
||||
"/_mozilla/css/list_style_fixed_inside_ref.html",
|
||||
"=="
|
||||
]
|
||||
],
|
||||
"url": "/_mozilla/css/list_style_fixed_inside_a.html"
|
||||
}
|
||||
],
|
||||
"css/list_style_image_sizing_a.html": [
|
||||
{
|
||||
"path": "css/list_style_image_sizing_a.html",
|
||||
|
@ -8634,4 +8658,4 @@
|
|||
"rev": null,
|
||||
"url_base": "/_mozilla/",
|
||||
"version": 2
|
||||
}
|
||||
}
|
||||
|
|
19
tests/wpt/mozilla/tests/css/list_style_fixed_inside_a.html
Normal file
19
tests/wpt/mozilla/tests/css/list_style_fixed_inside_a.html
Normal file
|
@ -0,0 +1,19 @@
|
|||
<!DOCTYPE html>
|
||||
<html>
|
||||
<head>
|
||||
<meta charset="utf-8">
|
||||
<link rel="match" href="list_style_fixed_inside_ref.html">
|
||||
<style>
|
||||
li {
|
||||
list-style-position: inside;
|
||||
position: fixed;
|
||||
}
|
||||
</style>
|
||||
</head>
|
||||
|
||||
<body>
|
||||
<ul>
|
||||
<li>x</li>
|
||||
</ul>
|
||||
</body>
|
||||
</html>
|
18
tests/wpt/mozilla/tests/css/list_style_fixed_inside_ref.html
Normal file
18
tests/wpt/mozilla/tests/css/list_style_fixed_inside_ref.html
Normal file
|
@ -0,0 +1,18 @@
|
|||
<!DOCTYPE html>
|
||||
<html>
|
||||
<head>
|
||||
<meta charset="utf-8">
|
||||
<style>
|
||||
li {
|
||||
list-style-position: inside;
|
||||
position: absolute;
|
||||
}
|
||||
</style>
|
||||
</head>
|
||||
|
||||
<body>
|
||||
<ul>
|
||||
<li>x</li>
|
||||
</ul>
|
||||
</body>
|
||||
</html>
|
Loading…
Add table
Add a link
Reference in a new issue