From 386973efeb574ebf99cd8a4f75d0b2856be63bf7 Mon Sep 17 00:00:00 2001 From: Anthony Ramine Date: Fri, 22 Sep 2017 14:08:25 +0200 Subject: [PATCH] Make Promise::new_resolved unsafe --- components/script/dom/promise.rs | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/components/script/dom/promise.rs b/components/script/dom/promise.rs index 45aff52f8fe..51b7c1763af 100644 --- a/components/script/dom/promise.rs +++ b/components/script/dom/promise.rs @@ -112,17 +112,15 @@ impl Promise { } #[allow(unrooted_must_root, unsafe_code)] - pub fn new_resolved( + pub unsafe fn new_resolved( global: &GlobalScope, cx: *mut JSContext, value: HandleValue, ) -> Fallible> { let _ac = JSAutoCompartment::new(cx, global.reflector().get_jsobject().get()); - rooted!(in(cx) let p = unsafe { CallOriginalPromiseResolve(cx, value) }); + rooted!(in(cx) let p = CallOriginalPromiseResolve(cx, value)); assert!(!p.handle().is_null()); - unsafe { - Ok(Promise::new_with_js_promise(p.handle(), cx)) - } + Ok(Promise::new_with_js_promise(p.handle(), cx)) } #[allow(unrooted_must_root, unsafe_code)]