Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 21:50:18 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #5942 - duncankl:whatwg-link-suggest, r=jdm

Browse source 
Simplified the checking logic a bit too; only a single match per line and a stricter regex that matches everything in one go.

I tested this against commit 8b08c6f4 and made sure it caught the same problems. Note that tidy doesn't currently check the webidls, so those would have still made it through.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5942)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2015-05-06 05:25:28 -05:00
commit 387836c42e
1 changed files with 4 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

10
python/tidy.py
View file

@ -72,12 +72,10 @@ def check_length(idx, line):
yield (idx + 1, "(much) overlong line")
def check_whatwg_url(idx, line):
matches = re.findall(r'whatwg.org/multipage.*#', line);
if matches:
for i, match in enumerate(matches):
parts = match.split('multipage')
if len(parts[1]) > 1 and parts[1][1] != '#':
yield (idx + 1, "URL should not point to specific WHATWG multipage page!")
match = re.search(r"https://html\.spec\.whatwg\.org/multipage/[\w-]+\.html#([\w\:-]+)", line)
if match is not None:
preferred_link = "https://html.spec.whatwg.org/multipage/#{}".format(match.group(1))
yield (idx + 1, "link to WHATWG may break in the future, use this format instead: {}".format(preferred_link))
def check_whitespace(idx, line):
if line[-1] == "\n":