mirror of
https://github.com/servo/servo.git
synced 2025-08-06 06:00:15 +01:00
Auto merge of #17739 - jdm:no-vendor-prefixed-errors, r=emilio
Suppress CSS parser errors for vendor-prefixed properties. This matches the behaviour of Gecko's CSS parser. - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #17736 - [X] There are tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17739) <!-- Reviewable:end -->
This commit is contained in:
commit
38f4ae80c4
9 changed files with 84 additions and 31 deletions
|
@ -316,7 +316,7 @@ fn test_report_error_stylesheet() {
|
|||
|
||||
let error = errors.pop().unwrap();
|
||||
assert_eq!("Unsupported property declaration: 'invalid: true;', \
|
||||
Custom(UnknownProperty(\"invalid\"))", error.message);
|
||||
Custom(PropertyDeclaration(UnknownProperty(\"invalid\")))", error.message);
|
||||
assert_eq!(9, error.line);
|
||||
assert_eq!(8, error.column);
|
||||
|
||||
|
@ -329,3 +329,30 @@ fn test_report_error_stylesheet() {
|
|||
// testing for the url
|
||||
assert_eq!(url, error.url);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn test_no_report_unrecognized_vendor_properties() {
|
||||
let css = r"
|
||||
div {
|
||||
-o-background-color: red;
|
||||
_background-color: red;
|
||||
-moz-background-color: red;
|
||||
}
|
||||
";
|
||||
let url = ServoUrl::parse("about::test").unwrap();
|
||||
let error_reporter = CSSInvalidErrorReporterTest::new();
|
||||
|
||||
let errors = error_reporter.errors.clone();
|
||||
|
||||
let lock = SharedRwLock::new();
|
||||
let media = Arc::new(lock.wrap(MediaList::empty()));
|
||||
Stylesheet::from_str(css, url, Origin::UserAgent, media, lock,
|
||||
None, &error_reporter, QuirksMode::NoQuirks, 0u64);
|
||||
|
||||
let mut errors = errors.lock().unwrap();
|
||||
let error = errors.pop().unwrap();
|
||||
assert_eq!("Unsupported property declaration: '-moz-background-color: red;', \
|
||||
Custom(PropertyDeclaration(UnknownProperty(\"-moz-background-color\")))",
|
||||
error.message);
|
||||
assert!(errors.is_empty());
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue