From 39e647de06b3d2c15f1fc99388a56972c7ae6883 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Emilio=20Cobos=20=C3=81lvarez?= Date: Mon, 23 Jul 2018 19:28:01 +0200 Subject: [PATCH] script: Fix the logic for mutation observer attributes. --- components/script/dom/mutationobserver.rs | 4 ++-- .../dom/nodes/MutationObserver-attributes.html.ini | 11 ----------- 2 files changed, 2 insertions(+), 13 deletions(-) delete mode 100644 tests/wpt/metadata/dom/nodes/MutationObserver-attributes.html.ini diff --git a/components/script/dom/mutationobserver.rs b/components/script/dom/mutationobserver.rs index ff01ce96ba9..65f8081c900 100644 --- a/components/script/dom/mutationobserver.rs +++ b/components/script/dom/mutationobserver.rs @@ -132,8 +132,8 @@ impl MutationObserver { if *namespace != ns!() { continue; } - if registered.options.attribute_filter.iter() - .find(|s| &**s == &**name).is_some() { + if !registered.options.attribute_filter.iter() + .any(|s| &**s == &**name) { continue; } } diff --git a/tests/wpt/metadata/dom/nodes/MutationObserver-attributes.html.ini b/tests/wpt/metadata/dom/nodes/MutationObserver-attributes.html.ini deleted file mode 100644 index 3adb1f43ffa..00000000000 --- a/tests/wpt/metadata/dom/nodes/MutationObserver-attributes.html.ini +++ /dev/null @@ -1,11 +0,0 @@ -[MutationObserver-attributes.html] - type: testharness - [attributes/attributeFilter Element.id/Element.className: update mutation] - expected: FAIL - - [attributes/attributeFilter Element.id/Element.className: multiple filter update mutation] - expected: FAIL - - [attributeFilter alone Element.id/Element.className: multiple filter update mutation] - expected: FAIL -