Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-29 16:19:14 +01:00
Code Issues Projects Releases Packages Wiki Activity

script: Always throw when trying to setProperty on a readonly style CSSStyleDeclaration (#38677)

Browse source 
Previously,
[`SetProperty`](https://drafts.csswg.org/cssom/#dom-cssstyledeclaration-setproperty)
implemented step 3 before calling into the inner `set_property` method,
which implements step 1. Therefore if step 3 returned then step 1 never
runs, and can't throw an exception.


Testing: A new web platform test starts to pass

---------

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
This commit is contained in:
Simon Wülker 2025-08-14 15:27:39 +02:00 • committed by GitHub
parent b747589286
commit 3a0e8fefde
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 54 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

4
tests/wpt/meta/css/cssom/computed-style-set-property.html.ini vendored
View file

@ -1,10 +1,6 @@
[computed-style-set-property.html]
[Exception thrown when trying to change a computed style alias via setProperty]
expected: FAIL
[Exception thrown when trying to change a computed style alias via property]
expected: FAIL
[Computed style parent (should be null)]
expected: FAIL