From b2cf27ba5d41f378da8a73607f2097e0b8688dbf Mon Sep 17 00:00:00 2001 From: Josh Matthews Date: Wed, 29 Jul 2015 12:39:26 -0400 Subject: [PATCH] Use an actual byte string when defining the prototype of named constructors. Fixes #6730. --- components/script/dom/bindings/utils.rs | 2 +- .../the-img-element/Image-constructor.html.ini | 6 ------ 2 files changed, 1 insertion(+), 7 deletions(-) delete mode 100644 tests/wpt/metadata/html/semantics/embedded-content/the-img-element/Image-constructor.html.ini diff --git a/components/script/dom/bindings/utils.rs b/components/script/dom/bindings/utils.rs index d29cc4d0c77..3a64b709ba3 100644 --- a/components/script/dom/bindings/utils.rs +++ b/components/script/dom/bindings/utils.rs @@ -233,7 +233,7 @@ pub fn do_create_interface_objects(cx: *mut JSContext, let constructor = RootedObject::new(cx, create_constructor(cx, cnative, cnargs, cs.as_ptr())); assert!(!constructor.ptr.is_null()); unsafe { - assert!(JS_DefineProperty1(cx, constructor.handle(), "prototype".as_ptr() as *const libc::c_char, + assert!(JS_DefineProperty1(cx, constructor.handle(), b"prototype\0".as_ptr() as *const libc::c_char, rval.handle(), JSPROP_PERMANENT | JSPROP_READONLY, None, None) != 0); diff --git a/tests/wpt/metadata/html/semantics/embedded-content/the-img-element/Image-constructor.html.ini b/tests/wpt/metadata/html/semantics/embedded-content/the-img-element/Image-constructor.html.ini deleted file mode 100644 index cf1b2d37e49..00000000000 --- a/tests/wpt/metadata/html/semantics/embedded-content/the-img-element/Image-constructor.html.ini +++ /dev/null @@ -1,6 +0,0 @@ -[Image-constructor.html] - type: testharness - [Image and HTMLImageElement share a prototype] - expected: - if not debug: FAIL -