mirror of
https://github.com/servo/servo.git
synced 2025-08-03 04:30:10 +01:00
Start having animations conform to the HTML spec
This is a small step toward fixing #19242. The main idea is that the clock for animations should advance as the event loop ticks. We accomplish this by moving the clock from layout and naming it the "animation timeline" which is the spec language. This should fix flakiness with animations and transitions tests where a reflow could move animations forward while script was running. This change also starts to break out transition and animation events into their own data structure, because it's quite likely that the next step in fixing #19242 is to no longer send these events through a channel.
This commit is contained in:
parent
b585ce5b1f
commit
3a74013abc
45 changed files with 159 additions and 2094 deletions
49
components/script/animation_timeline.rs
Normal file
49
components/script/animation_timeline.rs
Normal file
|
@ -0,0 +1,49 @@
|
|||
/* This Source Code Form is subject to the terms of the Mozilla Public
|
||||
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
||||
* file, You can obtain one at https://mozilla.org/MPL/2.0/. */
|
||||
|
||||
#![deny(missing_docs)]
|
||||
|
||||
//! A timeline module, used to specify an `AnimationTimeline` which determines
|
||||
//! the time used for synchronizing animations in the script thread.
|
||||
|
||||
use time;
|
||||
|
||||
/// A `AnimationTimeline` which is used to synchronize animations during the script
|
||||
/// event loop.
|
||||
#[derive(Clone, Copy, Debug, JSTraceable, MallocSizeOf)]
|
||||
pub struct AnimationTimeline {
|
||||
current_value: f64,
|
||||
}
|
||||
|
||||
impl AnimationTimeline {
|
||||
/// Creates a new "normal" timeline, i.e., a "Current" mode timer.
|
||||
#[inline]
|
||||
pub fn new() -> Self {
|
||||
Self {
|
||||
current_value: time::precise_time_s(),
|
||||
}
|
||||
}
|
||||
|
||||
/// Creates a new "test mode" timeline, with initial time 0.
|
||||
#[inline]
|
||||
pub fn new_for_testing() -> Self {
|
||||
Self { current_value: 0. }
|
||||
}
|
||||
|
||||
/// Returns the current value of the timeline in seconds.
|
||||
pub fn current_value(&self) -> f64 {
|
||||
self.current_value
|
||||
}
|
||||
|
||||
/// Updates the value of the `AnimationTimeline` to the current clock time.
|
||||
pub fn update(&mut self) {
|
||||
self.current_value = time::precise_time_s();
|
||||
}
|
||||
|
||||
/// Increments the current value of the timeline by a specific number of seconds.
|
||||
/// This is used for testing.
|
||||
pub fn advance_specific(&mut self, by: f64) {
|
||||
self.current_value += by;
|
||||
}
|
||||
}
|
Loading…
Add table
Add a link
Reference in a new issue