Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-04 05:00:08 +01:00
Code Issues Projects Releases Packages Wiki Activity

Do not render controls until we have metadata

Browse source
This commit is contained in:
Fernando Jiménez Moreno 2019-05-10 20:41:06 +02:00
parent f16cf2d6a4
commit 3a99c6ba6a
1 changed files with 9 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

9
components/script/dom/htmlmediaelement.rs
View file

@ -1648,6 +1648,12 @@ impl HTMLMediaElement {
// https://github.com/servo/media/issues/156 // https://github.com/servo/media/issues/156
// Step 12 & 13 are already handled by the earlier media track processing. // Step 12 & 13 are already handled by the earlier media track processing.
// We wait until we have metadata to render the controls, so we render them
// with the appropriate size.
if self.Controls() {
self.render_controls();
}
}, },
PlayerEvent::NeedData => { PlayerEvent::NeedData => {
// The player needs more data. // The player needs more data.
@ -1725,6 +1731,9 @@ impl HTMLMediaElement {
} }
fn render_controls(&self) { fn render_controls(&self) {
if self.ready_state.get() < ReadyState::HaveMetadata {
return;
}
// XXX cannot render controls while parsing. // XXX cannot render controls while parsing.
// XXX check that controls are not already rendered. // XXX check that controls are not already rendered.
let element = self.htmlelement.upcast::<Element>(); let element = self.htmlelement.upcast::<Element>();