Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-04 13:10:20 +01:00
Code Issues Projects Releases Packages Wiki Activity

Avoid sending idle message more than once after a reflow is complete

Browse source
This commit is contained in:
kingdido999 2018-12-13 10:53:31 -08:00
parent eab848df3e
commit 3b855b1329
1 changed files with 10 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

13
components/script/dom/window.rs
View file

@ -289,6 +289,10 @@ pub struct Window {
/// Webrender API Sender /// Webrender API Sender
#[ignore_malloc_size_of = "defined in webrender_api"] #[ignore_malloc_size_of = "defined in webrender_api"]
webrender_api_sender: RenderApiSender, webrender_api_sender: RenderApiSender,
/// Indicate whether a SetDocumentStatus message has been sent after a reflow is complete.
/// It is used to avoid sending idle message more than once, which is unneccessary.
has_sent_idle_message: Cell<bool>,
} }
impl Window { impl Window {
@ -1548,12 +1552,14 @@ impl Window {
elem.has_class(&atom!("reftest-wait"), CaseSensitivity::CaseSensitive) elem.has_class(&atom!("reftest-wait"), CaseSensitivity::CaseSensitive)
}); });
let ready_state = document.ReadyState(); let has_sent_idle_message = self.has_sent_idle_message.get();
let is_ready_state_complete = document.ReadyState() == DocumentReadyState::Complete;
let pending_images = self.pending_layout_images.borrow().is_empty(); let pending_images = self.pending_layout_images.borrow().is_empty();
if ready_state == DocumentReadyState::Complete && !reftest_wait && pending_images {
if !has_sent_idle_message && is_ready_state_complete && !reftest_wait && pending_images {
let event = ScriptMsg::SetDocumentState(DocumentState::Idle); let event = ScriptMsg::SetDocumentState(DocumentState::Idle);
self.send_to_constellation(event); self.send_to_constellation(event);
self.has_sent_idle_message.set(true);
} }
} }
@ -2101,6 +2107,7 @@ impl Window {
webrender_document, webrender_document,
exists_mut_observer: Cell::new(false), exists_mut_observer: Cell::new(false),
webrender_api_sender, webrender_api_sender,
has_sent_idle_message: Cell::new(false),
}); });
unsafe { WindowBinding::Wrap(runtime.cx(), win) } unsafe { WindowBinding::Wrap(runtime.cx(), win) }