Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 04:30:10 +01:00
Code Issues Projects Releases Packages Wiki Activity

Python 'is' operator should not be used to check value

Browse source 
'is' checks reference. '==' checks value
This commit is contained in:
Corey Farwell 2015-09-20 12:39:18 -04:00
parent 38bbdd80db
commit 3b99893eaa
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
components/script/dom/bindings/codegen/CodegenRust.py
View file

@ -1364,7 +1364,7 @@ class PropertyDefiner:
returns a tuple suitable for substitution into specTemplate. returns a tuple suitable for substitution into specTemplate.
""" """
assert len(array) is not 0 assert len(array) != 0
specs = [] specs = []
for member in array: for member in array:
@ -4156,7 +4156,7 @@ class CGDOMJSProxyHandler_defineProperty(CGAbstractExternMethod):
indexedSetter = self.descriptor.operations['IndexedSetter'] indexedSetter = self.descriptor.operations['IndexedSetter']
if indexedSetter: if indexedSetter:
if not (self.descriptor.operations['IndexedCreator'] is indexedSetter): if self.descriptor.operations['IndexedCreator'] != indexedSetter:
raise TypeError("Can't handle creator that's different from the setter") raise TypeError("Can't handle creator that's different from the setter")
set += ("let index = get_array_index_from_id(cx, id);\n" + set += ("let index = get_array_index_from_id(cx, id);\n" +
"if let Some(index) = index {\n" + "if let Some(index) = index {\n" +
@ -4173,7 +4173,7 @@ class CGDOMJSProxyHandler_defineProperty(CGAbstractExternMethod):
namedSetter = self.descriptor.operations['NamedSetter'] namedSetter = self.descriptor.operations['NamedSetter']
if namedSetter: if namedSetter:
if not self.descriptor.operations['NamedCreator'] is namedSetter: if self.descriptor.operations['NamedCreator'] != namedSetter:
raise TypeError("Can't handle creator that's different from the setter") raise TypeError("Can't handle creator that's different from the setter")
set += ("if RUST_JSID_IS_STRING(id) != 0 {\n" + set += ("if RUST_JSID_IS_STRING(id) != 0 {\n" +
CGIndenter(CGProxyNamedSetter(self.descriptor)).define() + CGIndenter(CGProxyNamedSetter(self.descriptor)).define() +