mirror of
https://github.com/servo/servo.git
synced 2025-08-05 21:50:18 +01:00
add CanGc as argument to methods in HTMLCollection, HTMLDataListElement, HTMLDialogElement, HTMLElement, HTMLFieldSetElement, HTMLFormControlsCollection, HTMLFormElement, HTMLIFrameElement (#36495)
add CanGc as argument to methods in HTMLCollection, HTMLDataListElement, HTMLDialogElement, HTMLElement, HTMLFieldSetElement, HTMLFormControlsCollection, HTMLFormElement, HTMLIFrameElement Testing: These changes do not require tests because they are a refactor. Addresses part of https://github.com/servo/servo/issues/34573. Signed-off-by: Yerkebulan Tulibergenov <yerkebulan@gmail.com>
This commit is contained in:
parent
06f86f88a2
commit
3babf74986
14 changed files with 69 additions and 60 deletions
|
@ -99,13 +99,13 @@ impl HTMLDialogElementMethods<crate::DomTypeHolder> for HTMLDialogElement {
|
|||
}
|
||||
|
||||
// https://html.spec.whatwg.org/multipage/#dom-dialog-close
|
||||
fn Close(&self, return_value: Option<DOMString>) {
|
||||
fn Close(&self, return_value: Option<DOMString>, can_gc: CanGc) {
|
||||
let element = self.upcast::<Element>();
|
||||
let target = self.upcast::<EventTarget>();
|
||||
|
||||
// Step 1 & 2
|
||||
if element
|
||||
.remove_attribute(&ns!(), &local_name!("open"), CanGc::note())
|
||||
.remove_attribute(&ns!(), &local_name!("open"), can_gc)
|
||||
.is_none()
|
||||
{
|
||||
return;
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue