Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-22 23:03:42 +01:00
Code Issues Projects Releases Packages Wiki Activity

compositor: Remove the script channel from the compositor (#36089)

Browse source 
This is a clean up after #36062 and #35985. It removes the script
channel for each pipeline from the compositor. Now all messages are sent
via the `Constellation` first, which will allow breaking the dependency
on script in the compositor.

In addition, scroll states are actually sent via the `Constellation`,
which was an oversight from #36062. Finally, a typo in a method name is
fixed.

Signed-off-by: Martin Robinson <mrobinson@igalia.com>
This commit is contained in:
Martin Robinson 2025-03-23 12:19:27 +01:00 • committed by GitHub
parent 5ed2eb62ec
commit 3c51df0f1b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 12 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

8
components/script/script_thread.rs
View file

@ -1878,16 +1878,12 @@ impl ScriptThread {
panic!("should have handled {:?} already", msg)
},
ScriptThreadMessage::SetScrollStates(pipeline_id, scroll_states) => {
self.handle_set_scroll_states_offsets(pipeline_id, scroll_states)
self.handle_set_scroll_states(pipeline_id, scroll_states)
},
}
}
fn handle_set_scroll_states_offsets(
&self,
pipeline_id: PipelineId,
scroll_states: Vec<ScrollState>,
) {
fn handle_set_scroll_states(&self, pipeline_id: PipelineId, scroll_states: Vec<ScrollState>) {
let Some(window) = self.documents.borrow().find_window(pipeline_id) else {
warn!("Received scroll states for closed pipeline {pipeline_id}");
return;