mirror of
https://github.com/servo/servo.git
synced 2025-08-01 19:50:30 +01:00
Fix HtmlLabelElement activation to run on correct element
Also removes old code that caused radio button clicks on disabled elements
This commit is contained in:
parent
183772583f
commit
3c7e6a4be8
2 changed files with 9 additions and 10 deletions
|
@ -861,10 +861,6 @@ impl VirtualMethods for HTMLInputElement {
|
|||
}
|
||||
|
||||
if event.type_() == atom!("click") && !event.DefaultPrevented() {
|
||||
if let InputType::InputRadio = self.input_type.get() {
|
||||
self.update_checked_state(true, true);
|
||||
}
|
||||
|
||||
// TODO: Dispatch events for non activatable inputs
|
||||
// https://html.spec.whatwg.org/multipage/#common-input-element-events
|
||||
|
||||
|
|
|
@ -63,12 +63,15 @@ impl Activatable for HTMLLabelElement {
|
|||
|
||||
// https://html.spec.whatwg.org/multipage/#run-post-click-activation-steps
|
||||
fn activation_behavior(&self, _event: &Event, _target: &EventTarget) {
|
||||
synthetic_click_activation(self.upcast::<Element>(),
|
||||
false,
|
||||
false,
|
||||
false,
|
||||
false,
|
||||
ActivationSource::NotFromClick);
|
||||
if let Some(e) = self.GetControl() {
|
||||
let elem = e.upcast::<Element>();
|
||||
synthetic_click_activation(elem,
|
||||
false,
|
||||
false,
|
||||
false,
|
||||
false,
|
||||
ActivationSource::NotFromClick);
|
||||
}
|
||||
}
|
||||
|
||||
// https://html.spec.whatwg.org/multipage/#implicit-submission
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue