Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-23 23:33:43 +01:00
Code Issues Projects Releases Packages Wiki Activity

clippy: Fix some clippy warnings in components/script (#31843)

Browse source 
* deref on an immutable reference

* fix deref on an immutable reference

* fix deref on an immutable reference
This commit is contained in:
Rosemary Ajayi 2024-03-25 12:57:35 +00:00 • committed by GitHub
parent 97144ddf71
commit 3d10dbae32
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

4
components/script/dom/servoparser/mod.rs
View file

@ -1187,7 +1187,7 @@ impl TreeSink for Sink {
.GetParentNode() .GetParentNode()
.expect("append_before_sibling called on node without parent"); .expect("append_before_sibling called on node without parent");
insert(&parent, Some(&*sibling), new_node, self.parsing_algorithm); insert(&parent, Some(sibling), new_node, self.parsing_algorithm);
} }
fn parse_error(&mut self, msg: Cow<'static, str>) { fn parse_error(&mut self, msg: Cow<'static, str>) {
@ -1253,7 +1253,7 @@ impl TreeSink for Sink {
fn remove_from_parent(&mut self, target: &Dom<Node>) { fn remove_from_parent(&mut self, target: &Dom<Node>) {
if let Some(ref parent) = target.GetParentNode() { if let Some(ref parent) = target.GetParentNode() {
parent.RemoveChild(&*target).unwrap(); parent.RemoveChild(target).unwrap();
} }
} }

6
components/script/dom/windowproxy.rs
View file

@ -636,7 +636,7 @@ impl WindowProxy {
((*get_object_class(window_jsobject.get())).flags & JSCLASS_IS_GLOBAL), ((*get_object_class(window_jsobject.get())).flags & JSCLASS_IS_GLOBAL),
0 0
); );
let _ac = enter_realm(&*window); let _ac = enter_realm(window);
// The old window proxy no longer owns this browsing context. // The old window proxy no longer owns this browsing context.
SetProxyReservedSlot(old_js_proxy.get(), 0, &PrivateValue(ptr::null_mut())); SetProxyReservedSlot(old_js_proxy.get(), 0, &PrivateValue(ptr::null_mut()));
@ -681,7 +681,7 @@ impl WindowProxy {
); );
} }
} }
self.set_window(&*globalscope, &PROXY_HANDLER); self.set_window(globalscope, &PROXY_HANDLER);
self.currently_active.set(Some(globalscope.pipeline_id())); self.currently_active.set(Some(globalscope.pipeline_id()));
} }
@ -691,7 +691,7 @@ impl WindowProxy {
} }
let globalscope = self.global(); let globalscope = self.global();
let window = DissimilarOriginWindow::new(&globalscope, self); let window = DissimilarOriginWindow::new(&globalscope, self);
self.set_window(&*window.upcast(), &XORIGIN_PROXY_HANDLER); self.set_window(window.upcast(), &XORIGIN_PROXY_HANDLER);
self.currently_active.set(None); self.currently_active.set(None);
} }

2
components/script/dom/workletglobalscope.rs
View file

@ -92,7 +92,7 @@ impl WorkletGlobalScope {
debug!("Evaluating Dom in a worklet."); debug!("Evaluating Dom in a worklet.");
rooted!(in (*GlobalScope::get_cx()) let mut rval = UndefinedValue()); rooted!(in (*GlobalScope::get_cx()) let mut rval = UndefinedValue());
self.globalscope.evaluate_js_on_global_with_result( self.globalscope.evaluate_js_on_global_with_result(
&*script, script,
rval.handle_mut(), rval.handle_mut(),
ScriptFetchOptions::default_classic_script(&self.globalscope), ScriptFetchOptions::default_classic_script(&self.globalscope),
self.globalscope.api_base_url(), self.globalscope.api_base_url(),